Fix dangling-doc-comments warnings#8559
Conversation
lkishalmi
left a comment
There was a problem hiding this comment.
OMG! This one kills my Firefox!
ebarboni
left a comment
There was a problem hiding this comment.
Huge tanks for doing this
neilcsmith-net
left a comment
There was a problem hiding this comment.
Thanks, looks good from what I can see.
My Firefox just about coping! 🤣
|
reviewing this via github is no fun, but one way of going through huge diffs is to look at the patch files of the individual commits I use also a browser plugin called I looked through it in NB, the vertical split button is very useful for that and I have prev/next mapped to mouse buttons. thanks for the reviews. Will merge once github resolved the problem with actions. |
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
fixes hundreds of javac warnings and avoids situations when comments wrongly show up as javadoc. - unintentional '///' - some dead (and commented out) code removal - some removal of decorative comments - fixed wrong annotation/doc ordering - various other dangling comment situations
|
will rebase and merge, github works again |
d4d1baf to
2a0acf0
Compare

fixes
hundredsthousands of javac warnings (dangling-doc-comments) and avoids situations when comments wrongly show up as javadoc.project wide, split into 7 commits across cluster boundaries (enterprise commit is the largest)
the remaining warnings are from generated code.
closes #8392