fix variable set but not used #2302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables will trigger variable 'ret' set but not used warnings due to different configurations. For using variables only in assert, added UNUSED to declare Warnings in external repositories are ignored in the makefile Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
This was referenced Feb 22, 2024
acassis
approved these changes
Feb 22, 2024
Contributor
|
Please verify the issues with sim/zipfs |
Contributor
|
I think it doesn't need with the new approach. Let's close it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These variables will trigger variable 'ret' set but not used warnings due to different configurations.
For using variables only in assert, added UNUSED to declare
Warnings in external repositories are ignored in the makefile
Impact
Let's ignore the following format check, which seems to have nothing to do with this change
Testing