Revert "assert: change the do-while of assert to a conditional expression"

[masayuki2009]

Reverts #11734
since there are many build failures.

[yf13]

@masayuki2009 I've sent #11739 in this repo and #2301 in apps repo, do you still want revert?

[masayuki2009]

@masayuki2009 I've sent #11739 in this repo and #2301 in apps repo, do you still want revert?

@yf13
Thanks, but I think it's not enough.

[xiaoxiang781216]

@masayuki2009 I've sent #11739 in this repo and #2301 in apps repo, do you still want revert?

@masayuki2009 let's fix the minor warning today instead reverting the changing?

[Gary-Hobson]

@masayuki2009 I've sent #11739 in this repo and #2301 in apps repo, do you still want revert?

@masayuki2009 let's fix the minor warning today instead reverting the changing?

This bug is fixed in the following two PRs：
#11742
apache/nuttx-apps#2302

[xiaoxiang781216]

Since DEBUGASSRT is nuttx specific macro, we can only change assert, so let's merge this patch first. @Gary-Hobson please provide a new patch which just change assert.