-
Notifications
You must be signed in to change notification settings - Fork 682
Revert commits from PR #2469 #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will submit a fix to lm3s6965 board |
|
This PR will fix the issue: apache/nuttx#12873 |
|
Hi @acassis , this PR is not related to the lm3s6965 board. Please, reconsider reviewing it and reverting ASAP. |
|
I will do some testing to verify this |
|
@tmedicci understood in fact the CI still breaking: https://github.com/apache/nuttx/actions/runs/10322320078/job/28577343134?pr=12873 |
yes, @acassis . It's breaking not because of the |
|
@tmedicci I understood, even the CI is failing: |
|
Let me try to fix it without reverting. I am doing some testing now. |
Summary
echo $?does not return any exit code. This is largely used by automated testing. This PR reverts it until it is properly fixed.Revert commits from PR #2469
Revert "nsh_fileapp: handle input redirection"
This reverts commit e46347e.
Revert "feat(nsh_cat): allow cat to read from stdin"
This reverts commit 8fba726.
Revert "feat(nsh): add console read"
This reverts commit 4104019.
Revert "feat(nsh): input (stdin) redirection"
This reverts commit 96100b3.
Impact
Fix
echo $?bug.Testing
Internal CI testing (HW testing with all supported Espressif SoCs)