Skip to content

fix(nsh_parse): handle env variables correctly #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acassis merged 1 commit into from
Aug 10, 2024
Merged

fix(nsh_parse): handle env variables correctly #2475

acassis merged 1 commit into from
Aug 10, 2024

Conversation

@casaroli
Copy link
Contributor

@casaroli casaroli commented Aug 10, 2024 •
edited
Loading

Summary

The PR #2469 broke handling of environment variables because an error in the if/else if control flow. I am sorry.

Thank you @tmedicci for reporting the problem. Here is the fix.

Impact

Fixes #2474:

NuttShell (NSH) NuttX-12.5.1
nsh> ls
/:
 bin/
 dev/
 etc/
 proc/
 tmp/
nsh> echo $?
0
nsh> ls lalala
nsh: ls: stat failed: 2
nsh> echo $?
1
nsh> ls lalala
nsh: ls: stat failed: 2
nsh> echo $? > /tmp/out
nsh> cat < /tmp/out
1
nsh>

Testing

Manually

@casaroli
fix(nsh_parse): handle env variables correctly
e54cebd 
The PR apache#2469 broke handling of environment variables because an
error in the if/else if control flow.

This fixes it.
@acassis acassis merged commit 0797ee2 into apache:master Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@tmedicci tmedicci tmedicci approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@casaroli @xiaoxiang781216 @tmedicci @acassis