-
Notifications
You must be signed in to change notification settings - Fork 689
Dynamic loading app update #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. Missing Information:
Recommendations:
By addressing these points, your PR will be more informative and easier for reviewers to evaluate. |
Contributor
Author
|
this pr depends on 13819 |
patacongo
reviewed
Oct 4, 2024
patacongo
reviewed
Oct 4, 2024
patacongo
reviewed
Oct 4, 2024
patacongo
reviewed
Oct 4, 2024
patacongo
reviewed
Oct 4, 2024
Contributor
Author
|
depends on 13852 |
xiaoxiang781216
approved these changes
Oct 8, 2024
f5657ab to
296686d
Compare
Contributor
Author
Member
|
I restarted the job, let's see if it works. Update: Nope it still fails. Why? |
d101c4a to
c25969f
Compare
5c7bd05 to
d5a36ab
Compare
Contributor
|
@anjiahao1 please fix: |
c2c9844 to
5308d45
Compare
we can build a module like app, use 'DYNLIB' mark current path is a loadable module and CFLAGSELF and CMODFLAGS can act on these compiled as loadable module Signed-off-by: anjiahao <anjiahao@xiaomi.com> Signed-off-by: wanggang26 <wanggang26@xiaomi.com> Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
…ation is completed and linking begin It is better to package the dynamic module into romfs after it is compiled. Signed-off-by: anjiahao <anjiahao@xiaomi.com>
… method Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
xiaoxiang781216
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
This PR replaces the dynamically loaded module_initialize function with the attribute((destructor)) keyword, and optimizes the compilation method for dynamic modules. Now, by simply adding the DYNLIB flag in the Makefile, the apps can be compiled as dynamic modules.
Impact
sotest/modprint
Testing
qemu with arm an547