Skip to content

unify MODULE & ELF flag to Toolchain.defs#13852

Merged
xiaoxiang781216 merged 3 commits intoapache:masterfrom
anjiahao1:100601
Oct 8, 2024
Merged

unify MODULE & ELF flag to Toolchain.defs#13852
xiaoxiang781216 merged 3 commits intoapache:masterfrom
anjiahao1:100601

Conversation

@anjiahao1
Copy link
Contributor

@anjiahao1 anjiahao1 commented Oct 6, 2024

Summary

unify MODULE & ELF flag to Toolchain.defs

Impact

elf & mod compile

Testing

sim:sotest

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: avr Issues related to all AVR(8-bit or 32-bit) architectures Arch: ceva Issues related to CEVA architecture Arch: mips Issues related to the MIPS architecture Arch: openrisc Issues related to the OpenRISC architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: sparc Issues related to the SPARC architecture Arch: tricore Issues related to the TriCore architecture from Infineon Arch: xtensa Issues related to the Xtensa architecture Arch: z16 Issues related to the Z16 architecture Arch: z80 Issues related to the Z80 architecture Area: Board support Board support issues Area: OS Components OS Components issues labels Oct 6, 2024
@github-actions
Copy link

github-actions bot commented Oct 6, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added the Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. label Oct 6, 2024
@anjiahao1 anjiahao1 mentioned this pull request Oct 6, 2024
Merged
xiaoxiang781216
xiaoxiang781216 reviewed Oct 6, 2024
View reviewed changes
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Oct 7, 2024

@anjiahao1 please fix the ci error.

@github-actions github-actions bot added Size: L The size of the change in this PR is large and removed Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Oct 7, 2024
@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 7, 2024 that may be closed by this pull request
CELFFLAGS and friends are abused in Application.mk apache/nuttx-apps#143
Closed
@anjiahao1
unify MODULE & ELF flag to Toolchain.defs
01c1706 
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1
dlcn:need select MODULES when compile
2fcf7ca 
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1
compiler:add visibility & constructor keywords in compiler.h
175246d 
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 4ac2a5a into apache:master Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: avr Issues related to all AVR(8-bit or 32-bit) architectures Arch: ceva Issues related to CEVA architecture Arch: mips Issues related to the MIPS architecture Arch: openrisc Issues related to the OpenRISC architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: sparc Issues related to the SPARC architecture Arch: tricore Issues related to the TriCore architecture from Infineon Arch: xtensa Issues related to the Xtensa architecture Arch: z16 Issues related to the Z16 architecture Arch: z80 Issues related to the Z80 architecture Area: Board support Board support issues Area: Build system Area: OS Components OS Components issues Size: L The size of the change in this PR is large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CELFFLAGS and friends are abused in Application.mk

2 participants

@anjiahao1 @xiaoxiang781216