{Bp-2655} examples: fix noteprint compile error #2770

jerpelea · 2024-10-25T07:38:20Z

Summary

fix noteprint compile error
The sched_note_string/bprintf/dump interfaces have been removed and replaced with printf and event

Impact

RELEASE

Testing

CI

Note
includes
#2596
#2614
#2650
#2677
#2681

The sched_note_string/bprintf/dump interfaces have been removed and replaced with printf and event Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>

noteprintf_main.c:52:7: warning: unused variable 'binary' [-Wunused-variable] 52 | } binary = Fix typo of sched. Signed-off-by: Neo Xu <neo.xu1990@gmail.com>

nuttxpr · 2024-10-25T07:46:47Z

[Experimental Bot, please feedback here]

This Pull Request appears to meet the basic NuttX requirements.

Here's a breakdown based on the provided information:

Strengths:

Summary: Clearly states the purpose of the PR ("fix noteprint compile error") and provides a concise explanation of the change ("sched_note_string/bprintf/dump interfaces replaced with printf and event").
Impact: Indicates the PR is a bug fix affecting the RELEASE (likely meaning it's a critical fix).
Testing: States that CI (Continuous Integration) was used for testing. This suggests automated tests were run.
Cross-referencing: Links a related NuttX Apps Pull Request, which is good practice for related changes.

Areas for Potential Improvement:

Impact (Specificity): While "RELEASE" suggests importance, a more detailed description of the impact would be helpful. For example:
- What functionality was broken before this fix?
- Which specific systems/configurations were affected by the compile error?
Testing (Details): While mentioning "CI" is a good start, providing a summary of the specific tests run (even if just the names or categories) would strengthen the PR.
Testing (Logs): The template requests "Testing logs before change" and "Testing logs after change." While you might not want to paste full logs into the PR description, consider:
- Attaching log files to the PR.
- Providing snippets of the most relevant log entries.
- Linking to external log storage if available.

Recommendation:

While the PR seems to meet the basic requirements, adding more details in the "Impact" and "Testing" sections will provide reviewers with a better understanding of the changes and their validation.

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>

gcov.c:61:6: warning: 'path' may be used uninitialized [-Wmaybe-uninitialized] 61 | if (path == NULL || access(path, F_OK) != 0 || atoi(strip) <= 0) | ^ gcov.c: In function 'gcov_main': gcov.c:79:19: note: 'path' was declared here 79 | FAR const char *path; Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>

1. struct rpmsg_ping_s ack change to cmd; 2. Update the help descrption based on the new cmd meaning; Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>

nsh_syscmds.c: In function ‘cmd_rpmsg_once’: nsh_syscmds.c:567:13: error: ‘RPMSGIOC_PANIC’ undeclared (first use in this function) 567 | cmd = RPMSGIOC_PANIC; | ^~~~~~~~~~~~~~ nsh_syscmds.c:567:13: note: each undeclared identifier is reported only once for each function it appears in nsh_syscmds.c:571:13: error: ‘RPMSGIOC_DUMP’ undeclared (first use in this function); did you mean ‘FIOC_DUMP’? 571 | cmd = RPMSGIOC_DUMP; Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

@Endcode

from the cmocka.h: * These headers or their equivalents MUST be included prior to including * this header file. * @code * #include <stdarg.h> * #include <stddef.h> * #include <stdint.h> * #include <setjmp.h> * @Endcode Signed-off-by: dulibo1 <dulibo1@xiaomi.com> Signed-off-by: buxiasen <buxiasen@xiaomi.com>

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

Signed-off-by: wanggang26 <wanggang26@xiaomi.com>

cederom

Thank you @jerpelea :-)

jerpelea · 2024-10-25T14:08:05Z

@lupyuen

the CI does not use the right branch
modified: boards/arm/mps/mps3-an547/configs/ap/defconfig
modified: boards/arm/mps/mps3-an547/configs/bl/defconfig

we do not have those configs in releases/12.7

@xiaoxiang781216 @cederom please ignore the errors and merge the change ASAP

lupyuen · 2024-10-26T00:37:42Z

the CI does not use the right branch

Thanks @jerpelea we're tracking the issue here:

[BUG] When building nuttx-apps, CI Workflow checks out the Incorrect Branch of nuttx repo nuttx#14513

Gary-Hobson and others added 2 commits October 25, 2024 09:35

examples: fix noteprint compile error

3c717d1

The sched_note_string/bprintf/dump interfaces have been removed and replaced with printf and event Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>

noteprintf: fix compile warnings

658d932

noteprintf_main.c:52:7: warning: unused variable 'binary' [-Wunused-variable] 52 | } binary = Fix typo of sched. Signed-off-by: Neo Xu <neo.xu1990@gmail.com>

jerpelea requested a review from xiaoxiang781216 October 25, 2024 07:38

github-actions bot added the Size: S label Oct 25, 2024

xiaoxiang781216 approved these changes Oct 25, 2024

View reviewed changes

Gary-Hobson and others added 11 commits October 25, 2024 13:55

system/gcov: supports generating device-side code coverage

0cf91cb

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>

system: adjust gcov configuration name

7105d68

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>

nsh_syscmds.c: upadate rpmsg ping help

2ee1ddc

1. struct rpmsg_ping_s ack change to cmd; 2. Update the help descrption based on the new cmd meaning; Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>

test case update follow the regualtor framework

a1b82e3

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

gpio:add example for wakeup gpio type

cc2be72

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

batterydump:move to system dir

21a013f

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

pmconfig:fix coverity scan issue which is unsigned_compare

0ce951d

Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

resetcause:restore to factory, factory to factory_inquiry

b79370d

Signed-off-by: wanggang26 <wanggang26@xiaomi.com>

github-actions bot added Size: M and removed Size: S labels Oct 25, 2024

xiaoxiang781216 approved these changes Oct 25, 2024

View reviewed changes

cederom approved these changes Oct 25, 2024

View reviewed changes

cederom merged commit a2e7624 into apache:releases/12.7 Oct 25, 2024

jerpelea deleted the bp-2655 branch October 25, 2024 14:13

lupyuen mentioned this pull request Oct 26, 2024

[BUG] When building nuttx-apps, CI Workflow checks out the Incorrect Branch of nuttx repo apache/nuttx#14513

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{Bp-2655} examples: fix noteprint compile error #2770

{Bp-2655} examples: fix noteprint compile error #2770

Uh oh!

jerpelea commented Oct 25, 2024 •

edited

Loading

Uh oh!

nuttxpr commented Oct 25, 2024

Uh oh!

cederom left a comment

Uh oh!

jerpelea commented Oct 25, 2024 •

edited

Loading

Uh oh!

lupyuen commented Oct 26, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

{Bp-2655} examples: fix noteprint compile error #2770

{Bp-2655} examples: fix noteprint compile error #2770

Uh oh!

Conversation

jerpelea commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Impact

Testing

Uh oh!

nuttxpr commented Oct 25, 2024

Uh oh!

cederom left a comment

Choose a reason for hiding this comment

Uh oh!

jerpelea commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lupyuen commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jerpelea commented Oct 25, 2024 •

edited

Loading

jerpelea commented Oct 25, 2024 •

edited

Loading

lupyuen commented Oct 26, 2024 •

edited

Loading