Skip to content

system/gcov: enhance gcov #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 3 commits into from
Oct 9, 2024
Merged

system/gcov: enhance gcov #2650

xiaoxiang781216 merged 3 commits into from
Oct 9, 2024

Conversation

@W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 8, 2024

Summary

  1. supports generating device-side code coverage
  2. adjust gcov configuration name
  3. deal compile warming

Impact

Testing

@Gary-Hobson @W-M-R
system/gcov: supports generating device-side code coverage
d9cd175 
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@Gary-Hobson @W-M-R
system: adjust gcov configuration name
8330ff2 
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@nuttxpr
Copy link

nuttxpr commented Oct 8, 2024

[Experimental Bot, please feedback here]

This PR summary is missing crucial information to determine if it meets NuttX requirements.

Missing Information:

  • Specifics on the change:
    • What "device-side code coverage" means and how it's implemented.
    • How the "gcov configuration name" is adjusted and why.
    • What "compile warnings" are addressed and how.
  • Impact details: ALL impact sections are empty. We need to understand:
    • What features are added/changed and how users are affected.
    • Build process changes, hardware/architecture implications.
    • Documentation needs, security considerations, compatibility impacts.
  • Testing Context:
    • What build hosts and target environments were used for verification?
    • The provided testing log sections are empty. Actual logs are needed.

To meet NuttX requirements, the PR needs to:

  1. Expand the Summary: Provide clear, concise explanations of each change.
  2. Complete the Impact section: Address ALL bullet points with specifics.
  3. Include Testing Details: Specify environments and provide REAL testing logs demonstrating the changes' effects.

@W-M-R
gcov.c: deal compile warming
f6194b1 
gcov.c:61:6: warning: 'path' may be used uninitialized [-Wmaybe-uninitialized]
   61 |   if (path == NULL || access(path, F_OK) != 0 || atoi(strip) <= 0)
      |      ^
gcov.c: In function 'gcov_main':
gcov.c:79:19: note: 'path' was declared here
   79 |   FAR const char *path;

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
@cederom
Copy link
Contributor

cederom commented Oct 8, 2024

CI errors, restarted :-)

@cederom
Copy link
Contributor

cederom commented Oct 9, 2024

Still CI errors :\

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Oct 9, 2024

Still CI errors :\

since it depends on apache/nuttx#13965, let's merge both together.

@xiaoxiang781216 xiaoxiang781216 merged commit a2964c7 into apache:master Oct 9, 2024
@W-M-R W-M-R deleted the gcov branch October 10, 2024 02:33
@jerpelea jerpelea mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

Size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@W-M-R @nuttxpr @cederom @xiaoxiang781216 @Gary-Hobson