Skip to content

Conversation

@W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 9, 2024

Summary

  1. adjust gcov configuration name and delete non-existent dependencie

Impact

No

Testing

No

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@github-actions github-actions bot added Area: Tooling Area: Build system Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Area: Board support Board support issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Oct 9, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Why is the change necessary? What problem does it solve?
    • What exactly is being changed? Be specific about the gcov configuration name and the "non-existent dependency."
    • How does the change work?
  • Impact:
    • While you mark most as "No," you must provide details if a change does impact users, builds, hardware, documentation, security, or compatibility. Don't just assume "No" is sufficient.
  • Testing:
    • "No" is not acceptable. You must provide testing logs to demonstrate the change's functionality. Include:
      • Specific build hosts and target environments used
      • Clear "before" and "after" logs showing the problem and the solution

Example of Improved Summary:

"This PR addresses an issue where the gcov configuration was incorrectly named 'xyz' instead of 'abc', causing build failures. Additionally, a non-existent dependency on library 'def' has been removed from the Makefile to streamline the build process."

Remember: A good PR is detailed, provides context, and offers evidence of testing.

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 47fc3a6 into apache:master Oct 9, 2024
@W-M-R W-M-R deleted the gcov branch October 10, 2024 02:29
@W-M-R W-M-R restored the gcov branch October 10, 2024 02:29
@W-M-R W-M-R deleted the gcov branch October 10, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Area: Board support Board support issues Area: Build system Area: OS Components OS Components issues Area: Tooling Board: simulator Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants