Skip to content

Conversation

@trns1997
Copy link
Contributor

@trns1997 trns1997 commented Sep 18, 2025

Note: Please adhere to Contributing Guidelines.

Summary

  • Please update Summary section.

Issue: #17016
Depends-on: apache/nuttx#17017

Impact

  • Please fill in Impact section.

Testing

  • Please fill in Testing section.

@trns1997
Copy link
Contributor Author

trns1997 commented Sep 18, 2025

@xiaoxiang781216 should i also add the same stage to the github action in the app? I feel like there is not need, but the build.yml seems to closesly mirror the build.yml from the nuttx repo

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trns1997 :-) Please take a look at [1] [2] [3] and update git commit message and PR description to match requirements :-)

[1] https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
[2] https://nuttx.apache.org/docs/latest/contributing/index.html
[3] https://nuttx.apache.org/docs/latest/contributing/coding_style.html

@xiaoxiang781216
Copy link
Contributor

@trns1997 you need fix ci error first
https://github.com/apache/nuttx-apps/actions/runs/17955938892/job/51067275467?pr=3185

CMake Error at /github/workspace/sources/apps/testing/cxx-oot-build/CMakeLists.txt:19 (add_executable):
  Cannot find source file:

    /github/workspace/sources/nuttx/src/HelloWorld.cpp

@trns1997
Copy link
Contributor Author

@trns1997 you need fix ci error first https://github.com/apache/nuttx-apps/actions/runs/17955938892/job/51067275467?pr=3185

CMake Error at /github/workspace/sources/apps/testing/cxx-oot-build/CMakeLists.txt:19 (add_executable):
  Cannot find source file:

    /github/workspace/sources/nuttx/src/HelloWorld.cpp

is there a mechanism to add this example folder in an ignore list?

@trns1997
Copy link
Contributor Author

trns1997 commented Sep 24, 2025

@trns1997 you need fix ci error first https://github.com/apache/nuttx-apps/actions/runs/17955938892/job/51067275467?pr=3185

CMake Error at /github/workspace/sources/apps/testing/cxx-oot-build/CMakeLists.txt:19 (add_executable):
  Cannot find source file:

    /github/workspace/sources/nuttx/src/HelloWorld.cpp

is there a mechanism to add this example folder in an ignore list?

@xiaoxiang781216 3 options. Either i place this cxx-oot-build in another place and i do not add_sub this folder in the root CMakeLists to avoid building this. Or i update nuttx_add_subdirectory function to accommodate an exclusion logic? Or I add a Guard inside the subproject itself? I have pushed changes with the guard approach lemme know what you guys think

@trns1997 trns1997 force-pushed the oot-build-test branch 2 times, most recently from 217ca6d to f9fbcaa Compare September 24, 2025 16:08
Add the source content for the out-of-tree build test
under `apps/testing/cxx-oot-build`. This supports the
new CI check in NuttX to prevent regressions in the
`make export` workflow.

The test project provides:
* Sample OOT build structure.
* Integration with exported `nuttx-export`.
* Verification of successful build and link.

Signed-off-by: trns1997 <trns1997@gmail.com>
@trns1997
Copy link
Contributor Author

@xiaoxiang781216 do we want to add the stage from https://github.com/apache/nuttx/pull/17017/files to the build.yml workflow file in the app as well? If yes, i suggest we merge this first, that way we can validate the pipeline succeed on nuttx and then once validated i'll create another PR to add the stage to nuttx-apps. What do you think?

@raiden00pl
Copy link
Member

Or i update nuttx_add_subdirectory function to accommodate an exclusion logic?

This solution seems to be the best: add an optional argument to nuttx_add_subdirectory() (like IGNORE_DIRS) where you can pass ignored directories. This can be a useful feature for later.

@trns1997
Copy link
Contributor Author

Or i update nuttx_add_subdirectory function to accommodate an exclusion logic?

This solution seems to be the best: add an optional argument to nuttx_add_subdirectory() (like IGNORE_DIRS) where you can pass ignored directories. This can be a useful feature for later.

ah @raiden00pl, i already implemented the guard approach. But i do not mind creating this feature in another PR. I do not want to mix this test with this feature. If you do not mind can you create the issue and assign it to me?

@xiaoxiang781216 xiaoxiang781216 merged commit 3684699 into apache:master Sep 25, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants