-
Notifications
You must be signed in to change notification settings - Fork 682
oot ci build test #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oot ci build test #3185
Conversation
|
@xiaoxiang781216 should i also add the same stage to the github action in the app? I feel like there is not need, but the build.yml seems to closesly mirror the build.yml from the nuttx repo |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trns1997 :-) Please take a look at [1] [2] [3] and update git commit message and PR description to match requirements :-)
[1] https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
[2] https://nuttx.apache.org/docs/latest/contributing/index.html
[3] https://nuttx.apache.org/docs/latest/contributing/coding_style.html
ce49756 to
c6822ff
Compare
|
@trns1997 you need fix ci error first |
c6822ff to
307e079
Compare
is there a mechanism to add this example folder in an ignore list? |
@xiaoxiang781216 3 options. Either i place this |
217ca6d to
f9fbcaa
Compare
Add the source content for the out-of-tree build test under `apps/testing/cxx-oot-build`. This supports the new CI check in NuttX to prevent regressions in the `make export` workflow. The test project provides: * Sample OOT build structure. * Integration with exported `nuttx-export`. * Verification of successful build and link. Signed-off-by: trns1997 <trns1997@gmail.com>
f9fbcaa to
f137327
Compare
|
@xiaoxiang781216 do we want to add the stage from https://github.com/apache/nuttx/pull/17017/files to the |
This solution seems to be the best: add an optional argument to |
ah @raiden00pl, i already implemented the guard approach. But i do not mind creating this feature in another PR. I do not want to mix this test with this feature. If you do not mind can you create the issue and assign it to me? |
Note: Please adhere to Contributing Guidelines.
Summary
Issue: #17016
Depends-on: apache/nuttx#17017
Impact
Testing