-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add cxx oot build test script to ci #17017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I’ve added a The script does the following:
It currently works locally, but I’d like some guidance on CI integration:
Looking for feedback on where this test should live in the CI pipeline and which boards we should cover. |
ping @leducp i would like your input on this plz :) |
We need to conserve CI resources due to Apache Foundation restrictions, so one representative board is enough. In the future we can include tests for various host OSes (Mac, Windows) but for now Linux is probably enough? I'm not sure where to run this script, probably we should add another job in the build workflow and call it directly: https://github.com/apache/nuttx/blob/master/.github/workflows/build.yml
|
Seems OK as a starter: having an export + OOT app build and linked to it is already years away from the current state :) |
Noted, i will treat this as a seperate test and add a new stage to |
|
@trns1997 please add entry to cxx-oot-build board profile in the Documentation/ please explain the details to test it. |
757f071 to
e361d2f
Compare
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trns1997 :-) Please take a look at [1] [2] [3] and update git commit message and PR description to match requirements :-)
[1] https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
[2] https://nuttx.apache.org/docs/latest/contributing/index.html
[3] https://nuttx.apache.org/docs/latest/contributing/coding_style.html
d4a7054 to
f6d9558
Compare
|
@trns1997 to test the Documentation: |
f6d9558 to
2f88fa5
Compare
60c6adf to
b2f21ed
Compare
|
@xiaoxiang781216 can we rerun just the last stage or should we rerun the entire pipeline? |
|
@trns1997 Everything needs to be redone. Here, nuttx-apps does not have the latest updates. nuttx/.github/workflows/build.yml Line 42 in 6a57c56
|
b2f21ed to
21f6e32
Compare
Introduce a new CI test to validate out-of-tree builds and prevent regressions in the `make export` workflow. Specifically, this change adds `test-oot-build.sh` that: * Builds NuttX using a selected configuration. * Runs `make export` to generate the export package. * Copies the `nuttx-export` to the OOT build project. * Verifies that compilation and linking succeed. Signed-off-by: trns1997 <trns1997@gmail.com>
21f6e32 to
df57b96
Compare
Note: Please adhere to Contributing Guidelines.
Summary
This PR introduces a new CI test for out-of-tree builds to prevent regressions in the make export workflow.
Specifically, it adds a test-oot-build.sh script that:
Issue: #17016
Provides: apache/nuttx-apps#3185
Depends-on: #16976
Impact
Testing