-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add make export to the ci to check if the archive is correctly exported #10534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@acassis @xiaoxiang781216 is there a simple way to test the CI locally? |
| CONFIG_SYMTAB_ORDEREDBYNAME=y | ||
| CONFIG_SYSTEM_NSH=y | ||
| CONFIG_UART0_SERIAL_CONSOLE=y | ||
| CONFIG_ARCH_BOARD_COMMON=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all board support common folder, it is wrong to add CONFIG_ARCH_BOARD_COMMON into ALL defconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to test, but if we use the exported archive (from make export) to build apps we have the error where it says cannot fine libboard.a. I am not sure it is true for all boards though soo I will test have to test that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @xiaoxiang781216, i was thinking of addressing this PR finally. I wanted your input regarding this discussing. Do you thins adding CONFIG_ARCH_BOARD_COMMON=y to boards that support common folder is acceptable? For now i was thinking of adding it to the STM32 boards and XMC4, or is it generally not a good idea and we want the user to be responsible for setting this option?
replace arm-01.dat with the test suite you want to run. |
I simply called the |
|
@trns1997 are you planing to adding a new PR about this matter? I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too. |
I am not sure, honestly i had forgotten about this PR. We could consider this approach #10388 (comment) . Let me know what you think, if you want i can look into it and create a new PR. |
|
done in #17017 |
Summary
CONFIG_ARCH_BOARD_COMMONto all defconfig by default for all boardsCloses #10388
Impact
Testing