Skip to content

Conversation

@trns1997
Copy link
Contributor

@trns1997 trns1997 commented Sep 7, 2023

Summary

  • Test make export archive in the CI
  • Add CONFIG_ARCH_BOARD_COMMON to all defconfig by default for all boards

Closes #10388

Impact

Testing

@trns1997 trns1997 marked this pull request as draft September 7, 2023 15:55
@trns1997 trns1997 changed the title Draft: add make export to the ci to check if the archive is correctly exported add make export to the ci to check if the archive is correctly exported Sep 7, 2023
@trns1997
Copy link
Contributor Author

trns1997 commented Sep 7, 2023

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

CONFIG_SYMTAB_ORDEREDBYNAME=y
CONFIG_SYSTEM_NSH=y
CONFIG_UART0_SERIAL_CONSOLE=y
CONFIG_ARCH_BOARD_COMMON=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all board support common folder, it is wrong to add CONFIG_ARCH_BOARD_COMMON into ALL defconfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test, but if we use the exported archive (from make export) to build apps we have the error where it says cannot fine libboard.a. I am not sure it is true for all boards though soo I will test have to test that out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @xiaoxiang781216, i was thinking of addressing this PR finally. I wanted your input regarding this discussing. Do you thins adding CONFIG_ARCH_BOARD_COMMON=y to boards that support common folder is acceptable? For now i was thinking of adding it to the STM32 boards and XMC4, or is it generally not a good idea and we want the user to be responsible for setting this option?

@xiaoxiang781216
Copy link
Contributor

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

  1. launch the docker used by ci from here:
    https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux
  2. Download nuttx/apps git
  3. run the follow command:
cd nuttx/tools/ci
./cibuild.sh -c -A -R testlist/arm-01.dat

replace arm-01.dat with the test suite you want to run.

@trns1997
Copy link
Contributor Author

trns1997 commented Sep 8, 2023

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

1. launch the docker used by ci from here:
   https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux

2. Download nuttx/apps git

3. run the follow command:
cd nuttx/tools/ci
./cibuild.sh -c -A -R testlist/arm-01.dat

replace arm-01.dat with the test suite you want to run.

I simply called the testbuild.sh in the tools directory to test if the build process works, which is more or less what you suggest but the fail variable always returns 1 is that normal for master?

@trns1997 trns1997 closed this Apr 24, 2024
@acassis
Copy link
Contributor

acassis commented Apr 24, 2024

@trns1997 are you planing to adding a new PR about this matter?

I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.

@trns1997
Copy link
Contributor Author

@trns1997 are you planing to adding a new PR about this matter?

I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.

I am not sure, honestly i had forgotten about this PR. We could consider this approach #10388 (comment) . Let me know what you think, if you want i can look into it and create a new PR.

@trns1997 trns1997 reopened this May 22, 2024
@trns1997
Copy link
Contributor Author

done in #17017

@trns1997 trns1997 closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libboard.a is not generated by make export

3 participants