-
Notifications
You must be signed in to change notification settings - Fork 1.5k
doc: Update CMake C++ guide #16970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update CMake C++ guide #16970
Conversation
|
ping @trns1997 |
|
I will follow the procedure step by step and get back :) |
e632c1c to
a3b1921
Compare
|
@leducp since some linker definitions are missing in the recent exports. I think we need to resolve this issue before coming back to this |
Indeed... 😥 |
@leducp , here #16976 (comment) i will resolve this in this PR. |
|
@leducp if you use this relates to this comment #16976 (comment) |
@leducp i can confirm it works :) here is the output: |
|
Honestly the |
OK so the exported toolchain was broken as suspected: waiting for #16976 before updating the doc again (and taking into account the comments). |
|
@leducp cherry-pick this commit plz: trns1997@ecd91aa, i tested this new procedure with these updates and everything works fine :) |
a3b1921 to
35ae78e
Compare
35ae78e to
5fc8d57
Compare
Use the exported CMake toolchain file instead of a custom and broken one. Slightly modify the C++ example code to introduce modern tools like auto keyword and shared_ptr Signed-off-by: Philippe Leduc <philippe.leduc@mailfence.com>
5fc8d57 to
2138956
Compare
Summary
Update the CMake C++ guide that is too outdated to be used.
Testing
Ongoing
close #16782