do ARLOCK things a bit differently #81
Conversation
This reverts commit 6707bfa.
Because macOS doesn't have flock.
|
i only tested on macOS |
| # macOS doesn't have flock. Use shlock instead. | ||
| AR := $(APPDIR)/tools/flock.sh $(APPDIR)/.arlock $(AR) | ||
| else | ||
| AR := flock $(APPDIR)/.arlock $(AR) |
There was a problem hiding this comment.
But I think this change still hit "@ can't find", I mention here:
apache/nuttx#342
since the symbol @ in side the original AR still pass to bash, but I can't understand why macOS no problem.
There was a problem hiding this comment.
AR doesn't have @. ARCHIVE does.
There was a problem hiding this comment.
But we can't bypass ARCHIVE and invoke AR directly, you can see there are mutiple ARCHIVE defintion in nuttx to fight or workaround the toolchain difference.
Actually, nuttx give the user freedom to provide own ARCHIVE defintion, so the ARCHIVE overload may exist more than we imagine.
There was a problem hiding this comment.
i checked some of ARCHIVE but they all seem calling AR one way or another.
you are right this doesn't work if ARCHIVE does something completely different.
i suspect it isn't the case though.
There was a problem hiding this comment.
Here is the case:
https://github.com/xiaoxiang781216/nuttx/blob/song-u1/arch/ceva/src/song/Toolchain.defs
You can see to support CEVA toolchain we have to do thing hard.
There was a problem hiding this comment.
ok, i'm now convinced. thank you for the pointer.
2 participants
No description provided.