-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Revert "README.txt: add MacOS section for flock installation" #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 7a76a97.
|
consider this after apache/nuttx-apps#81 |
But that patch will break some arch. If you really want to use shlock on macOS, it is better to add a bash script and call shlock/flock before check the platform, but keep ARCHIEVE call. |
|
@xiaoxiang781216 which arch does it break? |
Here: |
|
@xiaoxiang781216 it seems using AR via ARNOEMP. but i got your point. i wrote another alternative. how do you think? |
Has one concern, I reply in that PR. |
|
The z80 and z16 families are different becuse the ZDS II archiver will only archive one file at a time. |
|
@xiaoxiang781216: "we can't assume bash, can we?". Yes, in most cases you can assume bash or similar in all cases except Windows native build. You should try not to break the Windows native build any more that possible. That will be revisited in the near future. Has this discussion reached a conclusion? Is thie PR ready to be merged? |
|
This depend on which approach you want to fix the parellel build issue: |
This reverts commit 7a76a97.