-
Notifications
You must be signed in to change notification settings - Fork 1.5k
cmake(bugfix):Synchronize the compilation differences between CMake and Makefile in nuttx repo #13971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Experimental Bot, please feedback here] Yes, but with minor improvements: Meets Requirements:
Suggested Improvements:
Overall: Good start! Adding the specifics mentioned above will make this PR review much smoother. |
|
|
|
Hi @xuxin930 Sure now I try. |
|
I tried this PR locally Cmake Cmake+Ninja It is certainly related to the fact that Windows has a limit of 8192 characters for command line arguments. This does not seem an easy error to solve!!! Should we disable CMAKE + Ninja for Msys2 while waiting for a solution? |
@simbit18 nice catch! nuttx/arch/arm/src/cmake/gcc.cmake Lines 80 to 92 in 0647b49
|
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
|
@xuxin930 I will be away for a few days so if you decide to disable Cmake + Ninja for Msys2 just remove -N on build.yml for Nuttx nuttx/.github/workflows/build.yml Line 327 in 6ea3dca
|
|
@simbit18 sure, thanks for your suggestion. |
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>

Summary
sync CMake missing sources
There are differences between the current CMake base and Makefile.
This patch synchronizes the differences between modules
so that the CMake compilation content should be consistent with the Makefile.
Impact
[arm ach, fs, sched, mm , libc, drivers]
Testing
all CI build