-
Notifications
You must be signed in to change notification settings - Fork 682
build.yml[bugfix]:disable CMake Ninja for Msys2 #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @xuxin930 :-)
[1] https://discourse.slicer.org/t/long-path-using-ninja/1702 |
@cederom Yes, we actually split the AR process in CMake to avoid this. refer:apache/nuttx#13971 |
CI in the msys2 environment, the CMake ninja generator will have a problem with parameters being too long Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
|
Okay I filled in a new Issue to remember this needs a fix :-) |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xuxin930 :-) This is a quick fix, please update when fix for Ninja on msys2 is found :-)
lupyuen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi, before we disable -N on Msys2, let's try to solve the error. I cannot help you now, I will be able to look for a solution on Thursday of next week. I don't know if this way can help CMake variable CMAKE_NINJA_FORCE_RESPONSE_FILE to ON. https://cosylab.com/technology/a-compact-and-fast-build-system-fit-for-a-ninja/ |
|
Let's discuss it here apache/nuttx#14014 |
thanks @lupyuen NuttX repo has been merged apache/nuttx#14014 |
|
@simbit18 you can revert the change after fixing the problem. |
Summary
parameter list too longerrors.Impact
Testing