Skip to content

Conversation

@lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 8, 2024

Summary

This PR syncs the CI Build Workflow build.yml from nuttx repo to nuttx-apps. The updated build.yml consolidates these changes:

build.yml from nuttx repo was slightly modified for nuttx-apps:

  • All References to apache/nuttx/.../arch.yml were changed to apache/nuttx-apps/.../arch.yml (we decouple them so they are easier to update)
  • Removed pull_request > paths-ignore and push > paths-ignore (following the existing convention)

Impact

With the updated build.yml, nuttx-apps will be built according to the PR Arch Labels, as explained here: apache/nuttx#13775

This has no impact on nuttx-apps, since Arch Labels are not used in this repo. CI Build Workflow shall run the exact same way as before.

Testing

We verified that CI Build Workflow runs the exact same way as before.

With the updated build.yml, CI Build Workflow successfully recompiles examples/hello when we Submit a PR: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11229943812

Also when we Merge a PR: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11230244326

This PR syncs the CI Build Workflow `build.yml` from `nuttx` repo to `nuttx-apps`. The updated `build.yml` consolidates these changes:
- apache/nuttx#13301
- apache/nuttx#13806
- apache/nuttx#13862

`build.yml` from `nuttx` repo was slightly modified for `nuttx-apps`:
- All References to `apache/nuttx/.../arch.yml` were changed to `apache/nuttx-apps/.../arch.yml` (we decouple them so they are easier to update)
- Removed `pull_request > paths-ignore` and `push > paths-ignore` (following the existing convention)
@nuttxpr
Copy link

nuttxpr commented Oct 8, 2024

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements.

Here's a breakdown:

  • Summary: The summary clearly explains the purpose of the change (syncing CI workflow), the affected code (build.yml), and the specific changes made. It also provides links to related PRs.
  • Impact: The impact section thoroughly addresses each point:
    • No new features are added, existing features remain unchanged.
    • No impact on users, build process, hardware, documentation, security, or compatibility.
    • The impact on the CI workflow is clearly explained (no functional change, just code syncing).
  • Testing:
    • While the testing section doesn't specify the host and target details, it provides links to successful CI runs, demonstrating that the changes work as intended.

Suggestion:

  • For completeness, consider adding specific details about your testing environment (host OS, target architecture/board, etc.) to the Testing section.

Overall, the PR is well-documented and meets the NuttX requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhance the CI Workflow to skip the Unmodified Architectures

3 participants