Skip to content

Conversation

@lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 3, 2024

Summary

When building a branch like releases/12.7, the CI Workflow incorrectly checks out the master branch of nuttx-apps, instead of releases/12.7. This PR fixes a typo in apps_ref, to check out the correct branch.

Impact

This will fix the Apps Build for NuttX Releases.

Testing

None

When building a branch like `releases/12.7`, the CI Workflow incorrectly checks out the `master` branch of `nuttx-apps`, instead of `releases/12.7`. This PR fixes a typo in `apps_ref`, to check out the correct branch.
@github-actions github-actions bot added Area: CI Size: XS The size of the change in this PR is very small labels Oct 3, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit 089b5e0 into apache:master Oct 3, 2024
@lupyuen
Copy link
Member Author

lupyuen commented Oct 3, 2024

Hi @jerpelea: I believe we need to merge this into releases/12.7, so that CI will check out the correct version of nuttx-apps? We might also need #13800, because it modifies build.yml earlier. Thanks!

lupyuen added a commit to lupyuen2/wip-nuttx-apps that referenced this pull request Oct 8, 2024
This PR syncs the CI Build Workflow `build.yml` from `nuttx` repo to `nuttx-apps`. The updated `build.yml` consolidates these changes:
- apache/nuttx#13301
- apache/nuttx#13806
- apache/nuttx#13862

`build.yml` from `nuttx` repo was slightly modified for `nuttx-apps`:
- All References to `apache/nuttx/.../arch.yml` were changed to `apache/nuttx-apps/.../arch.yml` (we decouple them so they are easier to update)
- Removed `pull_request > paths-ignore` and `push > paths-ignore` (following the existing convention)
xiaoxiang781216 pushed a commit to apache/nuttx-apps that referenced this pull request Oct 8, 2024
This PR syncs the CI Build Workflow `build.yml` from `nuttx` repo to `nuttx-apps`. The updated `build.yml` consolidates these changes:
- apache/nuttx#13301
- apache/nuttx#13806
- apache/nuttx#13862

`build.yml` from `nuttx` repo was slightly modified for `nuttx-apps`:
- All References to `apache/nuttx/.../arch.yml` were changed to `apache/nuttx-apps/.../arch.yml` (we decouple them so they are easier to update)
- Removed `pull_request > paths-ignore` and `push > paths-ignore` (following the existing convention)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants