Skip to content

Conversation

@jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Oct 9, 2024

Summary

reason:
1In the scenario of active waiting, context switching is inevitable, and we can eliminate redundant judgments.

code size
before
hujun5@hujun5-OptiPlex-7070:~/downloads1/vela_sim/nuttx$ size nuttx
text data bss dec hex filename
262848 49985 63893 376726 5bf96 nuttx

after
hujun5@hujun5-OptiPlex-7070:~/downloads1/vela_sim/nuttx$ size nuttx
text data bss dec hex filename
263324 49985 63893 377202 5c172 nuttx

reduce code size by -476

Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx

Impact

RELEASE

Testing

CI

reason:
1In the scenario of active waiting, context switching is inevitable, and we can eliminate redundant judgments.

code size
before
hujun5@hujun5-OptiPlex-7070:~/downloads1/vela_sim/nuttx$ size nuttx
   text    data     bss     dec     hex filename
 262848   49985   63893  376726   5bf96 nuttx

after
hujun5@hujun5-OptiPlex-7070:~/downloads1/vela_sim/nuttx$ size nuttx
   text    data     bss     dec     hex filename
 263324   49985   63893  377202   5c172 nuttx

reduce code size by  -476

Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic \
   -machine virt,virtualization=on,gic-version=3 \
   -net none -chardev stdio,id=con,mux=on -serial chardev:con \
   -mon chardev=con,mode=readline -kernel ./nuttx

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@jerpelea jerpelea changed the title {p-13418} sched: add nxsched_remove_self {Bp-13418} sched: add nxsched_remove_self Oct 9, 2024
@github-actions github-actions bot added Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Oct 9, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

NuttX PR Requirements Review

This PR does not meet the NuttX requirements.

Here's why:

  • Insufficient Summary: The summary lacks crucial information:
    • Unclear necessity: "eliminate redundant judgments" is vague. Explain what judgments are redundant and why.
    • Missing context: What is "active waiting" referring to? Which code section implements this?
    • No issue references: Are there related NuttX issues?
  • Incomplete Impact:
    • RELEASE Impact: This is not informative. State if this is a bug fix, enhancement, etc.
    • User impact: Will this change behavior for existing users?
    • Hardware/Architecture impact: Any specific architectures affected?
    • Security impact: Even if unlikely, address potential security implications.
  • Inadequate Testing:
    • CI is not enough: Local testing is mandatory. Specify build hosts and target details.
    • Missing logs: Provide relevant log snippets showing the issue before and the improvement after your change.

To improve this PR:

  1. Expand the Summary: Clearly articulate the problem, solution, and relevant context.
  2. Thoroughly address Impact: Analyze and document all potential impacts of the change.
  3. Provide Detailed Testing Information: List your local setup, include relevant log snippets, and ensure CI passes.

@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 9, 2024

apache/nuttx-apps#2661 needed

@xiaoxiang781216 xiaoxiang781216 merged commit 5f6eb29 into apache:releases/12.7 Oct 9, 2024
@lupyuen
Copy link
Member

lupyuen commented Oct 9, 2024

@jerpelea and @xiaoxiang781216: I think we need #13806 to check out the right version of nuttx-apps. The log shows that we're building with the master branch of nuttx-apps:

Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/master:refs/remotes/origin/master
  From https://github.com/apache/nuttx-apps
   * [new branch]      master     -> origin/master
Checking out the ref
  /usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
  Reset branch 'master'
  branch 'master' set up to track 'origin/master'.

https://github.com/apache/nuttx/actions/runs/11252972889/job/31287274002

@jerpelea jerpelea deleted the bp-13418 branch October 9, 2024 10:35
@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 9, 2024

@lupyuen on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: OS Components OS Components issues Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants