Skip to content

{Bp-2647} net: Remove IFF_DOWN flag to compatible with Linux/*BSD #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 1 commit into from
Oct 9, 2024
Merged

{Bp-2647} net: Remove IFF_DOWN flag to compatible with Linux/*BSD #2661

xiaoxiang781216 merged 1 commit into from
Oct 9, 2024

Conversation

@jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Oct 9, 2024

Summary

turn off interface by checking IFF_UP flag isn't set: apache/nuttx#1838

Impact

RELEASE

Testing

CI

@xiaoxiang781216 @jerpelea
net: Remove IFF_DOWN flag to compatible with Linux/*BSD
7e79769 
turn off interface by checking IFF_UP flag isn't set:
apache/nuttx#1838

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This was referenced Oct 9, 2024
Merged
Merged
@jerpelea jerpelea mentioned this pull request Oct 9, 2024
Merged
@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lack of details on the functional part of the code being changed.
    • No explanation of how the change works.
  • Impact:
    • Unclear what "RELEASE" means in this context.
    • Needs specific details about impact on users, build, hardware, documentation, security, compatibility, etc.
  • Testing:
    • "CI" is not sufficient. Specify the build hosts and targets used for testing.
    • No testing logs provided.

To meet the requirements, the PR needs to provide comprehensive information in all sections, including specific details and relevant logs.

This was referenced Oct 9, 2024
Merged
Merged
@xiaoxiang781216 xiaoxiang781216 merged commit f86baa7 into apache:releases/12.7 Oct 9, 2024
@jerpelea jerpelea deleted the bp-2647 branch October 9, 2024 10:40
@fdcavalcanti fdcavalcanti mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

Size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerpelea @nuttxpr @xiaoxiang781216