{Bp-13569} Revert "toolchain/ghs: Fix CONFIG_SCHED_CRITMONITOR_MAXTIME_XXX "zero…

[jerpelea]

Summary

… used for undefined preprocessing identifier" warnings"

move private define to public

This reverts commit 236678d.

Impact

RELEASE

Testing

CI

[nuttxpr]

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

• Summary:
  • Lacks a clear explanation of why the change is necessary. What were the problems caused by the original commit (236678d)?
  • What specific "undefined preprocessing identifier warnings" were encountered?
  • Which define is being moved from private to public and why?
• Impact:
  • Simply stating "RELEASE" is not sufficient. Explain the potential impact of this change on users, the build process, hardware, documentation, security, and compatibility. Provide details about:
    • Will users need to modify their code or configurations?
    • Will any build procedures be affected?
    • Are there implications for specific hardware architectures or boards?
    • Does this change introduce any security vulnerabilities or address existing ones?
    • Will this change break compatibility with previous versions of NuttX?
• Testing:
  • "CI" is not enough. Provide specific details about your local testing environment:
    • Host OS and version
    • Compiler and version
    • Target architecture and board configuration
  • Include relevant snippets of testing logs from both before and after the change, clearly demonstrating the issue and the fix.

Recommendations:

1. Expand the Summary: Provide a thorough explanation of the problem, the proposed solution, and the rationale behind it.
2. Detail the Impact: Analyze and describe all potential consequences of this change, especially if it could affect users or introduce compatibility issues.
3. Provide Specific Testing Information: Clearly outline your testing environment and include relevant log snippets that highlight the problem and the effectiveness of your fix.

A well-documented PR is crucial for maintainers to understand and review your changes effectively.

[jerpelea]

apache/nuttx-apps#2661 needed