Skip to content

Conversation

@jerpelea
Copy link
Contributor

Summary

Config multi line output to mode 3, so isort and black can agree with
each other:

3 - Vertical Hanging Indent

from third_party import (
lib1,
lib2,
lib3,
lib4,
)

Exit with error if python code needs to format

Impact

No impact.
Testing

CI build pass.

Make CI fail if format not pass.

Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
Config multi line output to mode 3, so isort and black can agree with
each other:
```
3 - Vertical Hanging Indent

from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)
```

Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
@jerpelea jerpelea requested a review from lupyuen October 15, 2024 11:49
@github-actions github-actions bot added Area: Tooling Area: CI Size: XS The size of the change in this PR is very small labels Oct 15, 2024
@jerpelea
Copy link
Contributor Author

@lupyuen

CI error
Run echo "::add-matcher::nuttx/.github/nxstyle.json"
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
python3-xyz, where xyz is the package you are trying to
install.

If you wish to install a non-Debian-packaged Python package,
create a virtual environment using python3 -m venv path/to/venv.
Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
sure you have python3-full installed.

If you wish to install a non-Debian packaged Python application,
it may be easiest to use pipx install xyz, which will manage a
virtual environment for you. Make sure you have pipx installed.

See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.
Error: Process completed with exit code 1.

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

@acassis @cederom Any idea what's this? Something we changed in the Python Environment recently? Thanks!

@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 15, 2024

fix backported #14335

@jerpelea
Copy link
Contributor Author

please merge

@cederom cederom merged commit 07c48eb into apache:releases/12.7 Oct 15, 2024
@jerpelea jerpelea deleted the bp-14253 branch October 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Tooling Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants