-
Notifications
You must be signed in to change notification settings - Fork 1.5k
risc-v/up_testset: Implement test-and-set with AMOSWAP #14857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It should be a bit more efficient to do compared to the LR/SC pair.
|
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. The provided information is far too vague and lacks crucial details. Here's a breakdown of what's missing:
Example of how to improve this PR description: SummaryThis PR replaces the existing LR/SC implementation of atomic test&set in the Impact
TestingBuild Host: Linux (Ubuntu 22.04), x86_64, GCC 11.2.0 Target: QEMU RISC-V virt machine (rv-virt:ksmp64 config) Testing logs before change: Testing logs after change: By providing this level of detail, reviewers can properly assess the PR and determine its suitability for inclusion in NuttX. |
|
I don't understand, that the implementation of AMOSWAP was introduced to the community a long time ago. |
|
Did the code xiaomi submitted actually go through a review? I really feel like swearing right now. @xiaoxiang781216 |
Sorry, The reason is as follows: |
anchao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep moving, please address the CI failure issue.
I think the CI error is a known issue and not caused by this patch: #14841 (comment) |
Summary
It should be a bit more efficient to do compared to the LR/SC pair.
Impact
Atomic test&set can be implemented with AMOSWAP, this way should be a bit more efficient even.
Testing
rv-virt:ksmp64
MPFS with SMP (not released yet)