Skip to content

Conversation

@hujun260
Copy link
Contributor

@hujun260 hujun260 commented Dec 2, 2024

Summary

CC: mqueue.c common/riscv_exit.c: In function 'up_exit': common/riscv_exit.c:65:33: error: 'tcb' undeclared (first use in this function); did you mean 'tcb_s'?
65 | g_running_tasks[this_cpu()] = tcb;
| ^~~
| tcb_s

Impact

riscv

Testing

ci

CC:  mqueue.c common/riscv_exit.c: In function 'up_exit':
common/riscv_exit.c:65:33: error: 'tcb' undeclared (first use in this function); did you mean 'tcb_s'?
   65 |   g_running_tasks[this_cpu()] = tcb;
      |                                 ^~~
      |                                 tcb_s

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: XS The size of the change in this PR is very small labels Dec 2, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit 64c3e97 into apache:master Dec 2, 2024
16 of 17 checks passed
@lupyuen
Copy link
Member

lupyuen commented Dec 3, 2024

Sorry @hujun260 rv-virt:knsh (32-bit) is crashing with an Instruction Page Fault:
https://gist.github.com/lupyuen/74c74050683721f1bbbedb21e026ac6f#file-special-qemu-riscv-knsh-log-L1414

$ git reset --hard 64c3e972a0a887d25ed9ec1a3da9070a9273c4e6
HEAD is now at 64c3e972a0 fix compile error
$ qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -kernel nuttx -bios opensbi-1.5-rv-bin/share/opensbi/ilp32/generic/firmware/fw_dynamic.bin -nographic
QEMU emulator version 9.1.1
OpenSBI v1.5
NuttShell (NSH) NuttX-12.7.0
nsh> uname -a
NuttX 12.7.0 64c3e972a0 Dec  3 2024 10:52:59 risc-v rv-virt
nsh> hello
Hello, World!!
riscv_exception: EXCEPTION: Instruction page fault. MCAUSE: 0000000c, EPC: c000bd60, MTVAL: c000bd60
riscv_exception: Segmentation fault in PID 2: /system/bin/init

I'm not sure if it's caused by this PR or the earlier PR (because the build failed between the PRs):

Before That: The Previous Commit is OK

Also Crashing: rv-virt:knsh64

Though rv-virt:nsh and rv-virt:nsh64 are OK

@hujun260
Copy link
Contributor Author

hujun260 commented Dec 3, 2024

Sorry @hujun260 rv-virt:knsh (32-bit) is crashing with an Instruction Page Fault: https://gist.github.com/lupyuen/74c74050683721f1bbbedb21e026ac6f#file-special-qemu-riscv-knsh-log-L1414

$ git reset --hard 64c3e972a0a887d25ed9ec1a3da9070a9273c4e6
HEAD is now at 64c3e972a0 fix compile error
$ qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -kernel nuttx -bios opensbi-1.5-rv-bin/share/opensbi/ilp32/generic/firmware/fw_dynamic.bin -nographic
QEMU emulator version 9.1.1
OpenSBI v1.5
NuttShell (NSH) NuttX-12.7.0
nsh> uname -a
NuttX 12.7.0 64c3e972a0 Dec  3 2024 10:52:59 risc-v rv-virt
nsh> hello
Hello, World!!
riscv_exception: EXCEPTION: Instruction page fault. MCAUSE: 0000000c, EPC: c000bd60, MTVAL: c000bd60
riscv_exception: Segmentation fault in PID 2: /system/bin/init

I'm not sure if it's caused by this PR or the earlier PR (because the build failed between the PRs):

Before That: The Previous Commit is OK

Also Crashing: rv-virt:knsh64

Though rv-virt:nsh and rv-virt:nsh64 are OK

I'll look into this issue

@hujun260
Copy link
Contributor Author

hujun260 commented Dec 3, 2024

Sorry @hujun260 rv-virt:knsh (32-bit) is crashing with an Instruction Page Fault: https://gist.github.com/lupyuen/74c74050683721f1bbbedb21e026ac6f#file-special-qemu-riscv-knsh-log-L1414

$ git reset --hard 64c3e972a0a887d25ed9ec1a3da9070a9273c4e6
HEAD is now at 64c3e972a0 fix compile error
$ qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -kernel nuttx -bios opensbi-1.5-rv-bin/share/opensbi/ilp32/generic/firmware/fw_dynamic.bin -nographic
QEMU emulator version 9.1.1
OpenSBI v1.5
NuttShell (NSH) NuttX-12.7.0
nsh> uname -a
NuttX 12.7.0 64c3e972a0 Dec  3 2024 10:52:59 risc-v rv-virt
nsh> hello
Hello, World!!
riscv_exception: EXCEPTION: Instruction page fault. MCAUSE: 0000000c, EPC: c000bd60, MTVAL: c000bd60
riscv_exception: Segmentation fault in PID 2: /system/bin/init

I'm not sure if it's caused by this PR or the earlier PR (because the build failed between the PRs):

Before That: The Previous Commit is OK
Also Crashing: rv-virt:knsh64
Though rv-virt:nsh and rv-virt:nsh64 are OK

I'll look into this issue

#15030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] macOS CI: Error: common/riscv_exit.c:65:33: error: 'tcb' undeclared (first use in this function);

4 participants