-
Notifications
You must be signed in to change notification settings - Fork 1.5k
riscv: Some judgments are missing #15030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and identifies the impacted architecture, it lacks crucial information. Here's what's missing:
The PR needs to be expanded to address these missing points before it can be considered complete. |
lupyuen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK with OSTest on rv-virt:knsh, rv-virt:knsh64 and rv-virt:nsh64. Thanks! :-)
9187345 to
7a2a52a
Compare
00acae1 to
cb4e3c2
Compare
This commit fixes the regression from apache#14984 Signed-off-by: hujun5 <hujun5@xiaomi.com>
Summary
This commit fixes the regression from #14984
Impact
riscv
Testing
ostest rv-virt:knsh