Fix an inverted logic in the following commit. #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yamt
commented
Jan 29, 2020
yamt
commented
commit 39bd9ff Author: YAMAMOTO Takashi <yamamoto@midokura.com> Date: Wed Jan 29 00:17:05 2020 +0900 sim: Prefix symbols with _ for non-ELF Namely for Mach-O. Leave __CYGWIN__ case as it is.
Merged
| # define SYMBOL(s) _##s | ||
| #endif | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
How about:
#ifdef __ELF__
# define SYMBOL(s) s
#else
# define SYMBOL(s) _##s
#endif
Like you change:
#ifdef __ELF__
.type SYMBOL(up_setjmp), @function
#endif
Also for up_setjmp64.S
Contributor
Author
There was a problem hiding this comment.
do you mean to merge CYGWIN block?
CYGWIN seems to use _ prefix for 32-bit but not for 64-bit.
so I feel it's better to keep it separate.
Contributor
There was a problem hiding this comment.
Yes, the separation is better.
Contributor
|
@xiaoxiang781216 I think you should merge this when you are comfortable with the changes. I think only you and Yamamoto Takashi are sufficiently familiar with the build issues to make the correct technical decisions. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.