-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Travis CI configuration #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This would have caught a recent bug: #181 |
|
This patch is the step 4, 5 of https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci |
We have to use Jenkins and server from Apache to conform Apache requirement: |
|
even if you don't activate it on this repo, this is convenient for people working on their fork on github. |
|
What is the harm in merging this to see how well it works. Is it not completely low-risk? |
| # | ||
| CONFIG_ARCH="sim" | ||
| CONFIG_ARCH_BOARD="sim" | ||
| CONFIG_ARCH_BOARD_SIM=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems out of place with the other commits in the PR. Perhaps it should be a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is required by other changes as otherwise ./nuttx just hangs after running the tests.
| @@ -0,0 +1,46 @@ | |||
| #! /bin/sh | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLEASE FIX: All .sh files reequire (currently) a BSD 3-clause license. No unlicensed shell scripts may come in.
(License will, eventually, be changed to Apache).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added apache license
.travis.yml
Outdated
| @@ -0,0 +1,17 @@ | |||
| sudo: required | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Do .yml files require licenses and headers? I would think the answer is YES. ??
I think that basically any that "executes" needs a license header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added apache license to this file too as this yaml file contains shell script snippets.
|
ASF policy on headers is reasonable clear [1], but if in doubt add a header. BSD headers should not be added to new files ASF ALv2 headers should be used. |
To make it easier to run on CI jobs.
Run sim:ostest on Linux and macOS.
|
i added apache license to shell scripts |
|
any takers? eventually i want to add windows build which i can't test locally. i guess it's possible as travis ci provides windows env. |
|
I think is great to have this code available, but maybe it should be placed in Maybe this preference of a separate repo for the CI code is not settled on stone and it can be reconsidered, but other people then will require to put their own scripts on main repo. Can the CircleCI script be rewritten to clone the testing repo and move the logic there? I know maybe is a PITA to move it, but maybe would be easier to be accepted, and that is what I have been doing for other CI scripts, like the Jenkins one I have under review in that repo: put a "placeholder" Jenkinsfile in main repo so the CI can "hook" to it and the actual logic in the testing one. [1] https://www.mail-archive.com/dev@nuttx.apache.org/msg00436.html |
|
Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh. Since github could: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any takers? eventually i want to add windows build which i can't test locally. i guess it's possible as travis ci provides windows env.
@yamt could you look this PR:
#261
Which provide a unified framework to the precheck for all configs in Linux env, but it design to cover macOS and Windows in mind, so you can provide the patch to enable Windows/macOS check.
|
Let's track CI issue by: |
No description provided.