Fix wait loop and void cast

arch/arm/src/a1x/a1x_irq.c

@@ -156,7 +156,7 @@ void up_irqinitialize(void)
     {
       putreg32(0x00000000, A1X_INTC_EN(i));   /* 0 disables corresponding interrupt */
       putreg32(0xffffffff, A1X_INTC_MASK(i)); /* 1 masks corresponding interrupt */
-      (void)getreg32(A1X_INTC_IRQ_PEND(i));   /* Reading status clears pending interrupts */
+      getreg32(A1X_INTC_IRQ_PEND(i));         /* Reading status clears pending interrupts */
     }
 
   /* Set the interrupt base address to zero.  We do not use the vectored
@@ -178,7 +178,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
-  (void)up_irq_enable();
+  up_irq_enable();
 #endif
 
   a1x_dumpintc("initial", 0);

arch/arm/src/a1x/a1x_pio.c

@@ -163,7 +163,7 @@ static int a1x_pio_interrupt(int irq, void *context)
             {
               /* Yes.. dispatch the interrupt */
 
-              (void)arm_doirq(irq, regs);
+              arm_doirq(irq, regs);
             }
 
           irq++;

arch/arm/src/a1x/a1x_serial.c

@@ -1528,31 +1528,31 @@ void up_earlyserialinit(void)
 void up_serialinit(void)
 {
 #ifdef CONSOLE_DEV
-  (void)uart_register("/dev/console", &CONSOLE_DEV);
+  uart_register("/dev/console", &CONSOLE_DEV);
 #endif
 #ifdef TTYS0_DEV
-  (void)uart_register("/dev/ttyS0", &TTYS0_DEV);
+  uart_register("/dev/ttyS0", &TTYS0_DEV);
 #endif
 #ifdef TTYS1_DEV
-  (void)uart_register("/dev/ttyS1", &TTYS1_DEV);
+  uart_register("/dev/ttyS1", &TTYS1_DEV);
 #endif
 #ifdef TTYS2_DEV
-  (void)uart_register("/dev/ttyS2", &TTYS2_DEV);
+  uart_register("/dev/ttyS2", &TTYS2_DEV);
 #endif
 #ifdef TTYS3_DEV
-  (void)uart_register("/dev/ttyS3", &TTYS3_DEV);
+  uart_register("/dev/ttyS3", &TTYS3_DEV);
 #endif
 #ifdef TTYS4_DEV
-  (void)uart_register("/dev/ttyS4", &TTYS4_DEV);
+  uart_register("/dev/ttyS4", &TTYS4_DEV);
 #endif
 #ifdef TTYS5_DEV
-  (void)uart_register("/dev/ttyS5", &TTYS5_DEV);
+  uart_register("/dev/ttyS5", &TTYS5_DEV);
 #endif
 #ifdef TTYS6_DEV
-  (void)uart_register("/dev/ttyS6", &TTYS6_DEV);
+  uart_register("/dev/ttyS6", &TTYS6_DEV);
 #endif
 #ifdef TTYS7_DEV
-  (void)uart_register("/dev/ttyS7", &TTYS7_DEV);
+  uart_register("/dev/ttyS7", &TTYS7_DEV);
 #endif
 }
 

arch/arm/src/a1x/a1x_timerisr.c

@@ -138,7 +138,7 @@ void arm_timer_initialize(void)
 
   /* Attach the timer interrupt vector */
 
-  (void)irq_attach(A1X_IRQ_TIMER0, (xcpt_t)a1x_timerisr, NULL);
+  irq_attach(A1X_IRQ_TIMER0, (xcpt_t)a1x_timerisr, NULL);
 
   /* Enable interrupts from the TIMER 0 port */
 

arch/arm/src/am335x/am335x_gpioirq.c

@@ -259,7 +259,7 @@ void am335x_gpio_irqinitialize(void)
 
   /* Attach and enable the GPIO0 IRQ */
 
-  (void)irq_attach(AM335X_IRQ_GPIO0A, am335x_gpio0_interrupt, NULL);
+  irq_attach(AM335X_IRQ_GPIO0A, am335x_gpio0_interrupt, NULL);
   up_enable_irq(AM335X_IRQ_GPIO0A);
 #endif
 
@@ -284,7 +284,7 @@ void am335x_gpio_irqinitialize(void)
 
   /* Attach and enable the GPIO1 IRQ */
 
-  (void)irq_attach(AM335X_IRQ_GPIO1A, am335x_gpio1_interrupt, NULL);
+  irq_attach(AM335X_IRQ_GPIO1A, am335x_gpio1_interrupt, NULL);
   up_enable_irq(AM335X_IRQ_GPIO1A);
 #endif
 
@@ -309,7 +309,7 @@ void am335x_gpio_irqinitialize(void)
 
   /* Attach and enable the GPIO2 IRQ */
 
-  (void)irq_attach(AM335X_IRQ_GPIO2A, am335x_gpio2_interrupt, NULL);
+  irq_attach(AM335X_IRQ_GPIO2A, am335x_gpio2_interrupt, NULL);
   up_enable_irq(AM335X_IRQ_GPIO2A);
 #endif
 
@@ -334,7 +334,7 @@ void am335x_gpio_irqinitialize(void)
 
   /* Attach and enable the GPIO3 IRQ */
 
-  (void)irq_attach(AM335X_IRQ_GPIO3A, am335x_gpio3_interrupt, NULL);
+  irq_attach(AM335X_IRQ_GPIO3A, am335x_gpio3_interrupt, NULL);
   up_enable_irq(AM335X_IRQ_GPIO3A);
 #endif
 }

arch/arm/src/am335x/am335x_irq.c

@@ -131,8 +131,8 @@ void up_irqinitialize(void)
   for (i = 0; i < AM335X_IRQ_NINT; i += 32)
     {
       putreg32(0xffffffff, AM335X_INTC_MIR_SET(i)); /* 1 masks corresponding interrupt */
-      (void)getreg32(AM335X_INTC_PEND_IRQ(i));   /* Reading status clears pending interrupts */
-      (void)getreg32(AM335X_INTC_PEND_FIQ(i));   /* Reading status clears pending interrupts */
+      getreg32(AM335X_INTC_PEND_IRQ(i));   /* Reading status clears pending interrupts */
+      getreg32(AM335X_INTC_PEND_FIQ(i));   /* Reading status clears pending interrupts */
     }
 
   /* currents_regs is non-NULL only while processing an interrupt */
@@ -150,7 +150,7 @@ void up_irqinitialize(void)
 
   /* And finally, enable interrupts */
 
-  (void)up_irq_enable();
+  up_irq_enable();
 #endif
 }
 

arch/arm/src/am335x/am335x_lcdc.c

@@ -585,7 +585,7 @@ int am335x_lcd_initialize(FAR const struct am335x_panel_info_s *panel)
 
   /* Initialize the device state singleton */
 
-  sem_init(&priv->exclsem, 0, 1);
+  nxsem_init(&priv->exclsem, 0, 1);
   memcpy(&priv->panel, panel, sizeof(struct am335x_panel_info_s));
 
   /* Save framebuffer information */

arch/arm/src/am335x/am335x_serial.c

@@ -1347,25 +1347,25 @@ void up_earlyserialinit(void)
 void up_serialinit(void)
 {
 #ifdef CONSOLE_DEV
-  (void)uart_register("/dev/console", &CONSOLE_DEV);
+  uart_register("/dev/console", &CONSOLE_DEV);
 #endif
 #ifdef TTYS0_DEV
-  (void)uart_register("/dev/ttyS0", &TTYS0_DEV);
+  uart_register("/dev/ttyS0", &TTYS0_DEV);
 #endif
 #ifdef TTYS1_DEV
-  (void)uart_register("/dev/ttyS1", &TTYS1_DEV);
+  uart_register("/dev/ttyS1", &TTYS1_DEV);
 #endif
 #ifdef TTYS2_DEV
-  (void)uart_register("/dev/ttyS2", &TTYS2_DEV);
+  uart_register("/dev/ttyS2", &TTYS2_DEV);
 #endif
 #ifdef TTYS3_DEV
-  (void)uart_register("/dev/ttyS3", &TTYS3_DEV);
+  uart_register("/dev/ttyS3", &TTYS3_DEV);
 #endif
 #ifdef TTYS4_DEV
-  (void)uart_register("/dev/ttyS4", &TTYS4_DEV);
+  uart_register("/dev/ttyS4", &TTYS4_DEV);
 #endif
 #ifdef TTYS5_DEV
-  (void)uart_register("/dev/ttyS5", &TTYS5_DEV);
+  uart_register("/dev/ttyS5", &TTYS5_DEV);
 #endif
 }
 

arch/arm/src/am335x/am335x_timerisr.c

@@ -154,7 +154,7 @@ void arm_timer_initialize(void)
 
   /* Attach the timer interrupt vector */
 
-  (void)irq_attach(AM335X_IRQ_TIMER1_1MS, (xcpt_t)am335x_timerisr, NULL);
+  irq_attach(AM335X_IRQ_TIMER1_1MS, (xcpt_t)am335x_timerisr, NULL);
 
   /* Clear interrupt status */
 
@@ -193,7 +193,7 @@ void arm_timer_initialize(void)
 
   /* Attach the timer interrupt vector */
 
-  (void)irq_attach(AM335X_IRQ_TIMER2, (xcpt_t)am335x_timerisr, NULL);
+  irq_attach(AM335X_IRQ_TIMER2, (xcpt_t)am335x_timerisr, NULL);
 
   /* Enable overflow interrupt */
 

arch/arm/src/arm/up_assert.c

@@ -290,7 +290,7 @@ static void up_dumpstate(void)
 #ifdef CONFIG_ARCH_USBDUMP
   /* Dump USB trace data */
 
-  (void)usbtrace_enumerate(assert_tracecallback, NULL);
+  usbtrace_enumerate(assert_tracecallback, NULL);
 #endif
 }
 #else
@@ -306,13 +306,13 @@ static void _up_assert(int errorcode)
 {
   /* Flush any buffered SYSLOG data */
 
-  (void)syslog_flush();
+  syslog_flush();
 
   /* Are we in an interrupt handler or the idle task? */
 
   if (CURRENT_REGS || running_task()->flink == NULL)
     {
-      (void)up_irq_save();
+      up_irq_save();
       for (; ; )
         {
 #if CONFIG_BOARD_RESET_ON_ASSERT >= 1
@@ -353,7 +353,7 @@ void up_assert(const uint8_t *filename, int lineno)
 
   /* Flush any buffered SYSLOG data (prior to the assertion) */
 
-  (void)syslog_flush();
+  syslog_flush();
 
 #if CONFIG_TASK_NAME_SIZE > 0
   _alert("Assertion failed at file:%s line: %d task: %s\n",
@@ -367,7 +367,7 @@ void up_assert(const uint8_t *filename, int lineno)
 
   /* Flush any buffered SYSLOG data (from the above) */
 
-  (void)syslog_flush();
+  syslog_flush();
 
 #ifdef CONFIG_BOARD_CRASHDUMP
   board_crashdump(up_getsp(), running_task(), filename, lineno);

arch/arm/src/arm/up_blocktask.c

@@ -161,7 +161,7 @@ void up_block_task(struct tcb_s *tcb, tstate_t task_state)
            * thread at the head of the ready-to-run list.
            */
 
-          (void)group_addrenv(rtcb);
+          group_addrenv(rtcb);
 #endif
           /* Reset scheduler parameters */
 

arch/arm/src/arm/up_doirq.c

@@ -119,7 +119,7 @@ void up_doirq(int irq, uint32_t *regs)
        * thread at the head of the ready-to-run list.
        */
 
-      (void)group_addrenv(NULL);
+      group_addrenv(NULL);
 #endif
     }
 #endif

arch/arm/src/arm/up_releasepending.c

@@ -130,7 +130,7 @@ void up_release_pending(void)
            * thread at the head of the ready-to-run list.
            */
 
-          (void)group_addrenv(rtcb);
+          group_addrenv(rtcb);
 #endif
           /* Update scheduler parameters */
 

arch/arm/src/arm/up_reprioritizertr.c

@@ -183,7 +183,7 @@ void up_reprioritize_rtr(struct tcb_s *tcb, uint8_t priority)
                * thread at the head of the ready-to-run list.
                */
 
-              (void)group_addrenv(rtcb);
+              group_addrenv(rtcb);
 #endif
               /* Update scheduler parameters */
 

arch/arm/src/arm/up_sigdeliver.c

@@ -107,7 +107,7 @@ void up_sigdeliver(void)
    */
 
   sinfo("Resuming\n");
-  (void)up_irq_save();
+  up_irq_save();
   rtcb->pterrno       = saved_errno;
 
   /* Modify the saved return state with the actual saved values in the

arch/arm/src/arm/up_unblocktask.c

@@ -145,7 +145,7 @@ void up_unblock_task(struct tcb_s *tcb)
            * thread at the head of the ready-to-run list.
            */
 
-          (void)group_addrenv(rtcb);
+          group_addrenv(rtcb);
 #endif
           /* Update scheduler parameters */
 

arch/arm/src/armv6-m/up_assert.c

@@ -347,7 +347,7 @@ static void up_dumpstate(void)
 #ifdef CONFIG_ARCH_USBDUMP
   /* Dump USB trace data */
 
-  (void)usbtrace_enumerate(assert_tracecallback, NULL);
+  usbtrace_enumerate(assert_tracecallback, NULL);
 #endif
 }
 #else
@@ -363,13 +363,13 @@ static void _up_assert(int errorcode)
 {
   /* Flush any buffered SYSLOG data */
 
-  (void)syslog_flush();
+  syslog_flush();
 
   /* Are we in an interrupt handler or the idle task? */
 
   if (CURRENT_REGS || running_task()->flink == NULL)
     {
-      (void)up_irq_save();
+      up_irq_save();
       for (; ; )
         {
 #if CONFIG_BOARD_RESET_ON_ASSERT >= 1
@@ -410,7 +410,7 @@ void up_assert(const uint8_t *filename, int lineno)
 
   /* Flush any buffered SYSLOG data (prior to the assertion) */
 
-  (void)syslog_flush();
+  syslog_flush();
 
 #if CONFIG_TASK_NAME_SIZE > 0
   _alert("Assertion failed at file:%s line: %d task: %s\n",
@@ -424,7 +424,7 @@ void up_assert(const uint8_t *filename, int lineno)
 
   /* Flush any buffered SYSLOG data (from the above) */
 
-  (void)syslog_flush();
+  syslog_flush();
 
 #ifdef CONFIG_BOARD_CRASHDUMP
   board_crashdump(up_getsp(), running_task(), filename, lineno);

arch/arm/src/armv6-m/up_hardfault.c

@@ -134,7 +134,7 @@ int up_hardfault(int irq, FAR void *context, FAR void *arg)
           getprimask(), getipsr());
 #endif
 
-  (void)up_irq_save();
+  up_irq_save();
   hfalert("PANIC!!! Hard fault\n");
   PANIC();
   return OK; /* Won't get here */

arch/arm/src/armv6-m/up_sigdeliver.c

@@ -111,7 +111,7 @@ void up_sigdeliver(void)
    */
 
   sinfo("Resuming\n");
-  (void)up_irq_save();
+  up_irq_save();
   rtcb->pterrno = saved_errno;
 
   /* Modify the saved return state with the actual saved values in the

arch/arm/src/armv6-m/up_signal_dispatch.c

@@ -84,8 +84,8 @@ void up_signal_dispatch(_sa_sigaction_t sighand, int signo,
 {
   /* Let sys_call4() do all of the work */
 
-  (void)sys_call4(SYS_signal_handler, (uintptr_t)sighand, (uintptr_t)signo,
-                  (uintptr_t)info, (uintptr_t)ucontext);
+  sys_call4(SYS_signal_handler, (uintptr_t)sighand, (uintptr_t)signo,
+            (uintptr_t)info, (uintptr_t)ucontext);
 }
 
 #endif /* (CONFIG_BUILD_PROTECTED || CONFIG_BUILD_KERNEL) && !CONFIG_DISABLE_PTHREAD */