-
Notifications
You must be signed in to change notification settings - Fork 1.5k
arch/risc-v: Refine Toolchain.defs #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Look like we should finish this PR: #2822 |
ee35c1b to
049cfaf
Compare
This PR will be finished in next phase, I will pick it later. |
|
Waiting for #5082 , and this patch will be rebased on it. |
84b171d to
891bc7e
Compare
|
@no1wudi there are some build error need to fix first. |
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Fixed |
|
This is giving me: Is there anything special I need to do to clear out old state? I just tried |
|
This patch merge Toolchain.defs from rv32im/rv64gc to common, so you may need make distclean and reconfigure again. |
|
I couldn't run |
|
Yes, copy Mak.defs can fix this problem too. |
Summary
Refine risc-v Toolchain.defs firstly, and it tested on qemu-rv32.
And then:
Impact
Refactor only.
Testing
Tested on qemu-rv32 and CI