Skip to content

arch/risc-v: Refine syscall interface #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 1 commit into from
Dec 30, 2021
Merged

arch/risc-v: Refine syscall interface #5115

xiaoxiang781216 merged 1 commit into from
Dec 30, 2021

Conversation

@no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Dec 29, 2021

Summary

Impact

Refactor only.

Testing

CI and rv32-virt:ostest

xiaoxiang781216
xiaoxiang781216 reviewed Dec 29, 2021
View reviewed changes
xiaoxiang781216
xiaoxiang781216 reviewed Dec 29, 2021
View reviewed changes
@no1wudi
arch/risc-v: Refine syscall interface
4c64024 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
xiaoxiang781216
xiaoxiang781216 approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiaoxiang781216 xiaoxiang781216 merged commit 2de2298 into apache:master Dec 30, 2021
@masayuki2009
Copy link
Contributor

masayuki2009 commented Dec 30, 2021 •
edited
Loading

@no1wudi

Hmm, hifive1-revb:nsh with QEMU crashes with this PR.
Could you please take a look at what is happening with this PR?

NuttShell (NSH) NuttX-10.2.0
nsh> up_assert: Assertion failed at file:irq/irq_unexpectedisr.c line: 51 task: Idle Task
riscv_registerdump: EPC:20403580
riscv_registerdump: A0:00000002 A1:80000700 A2:800015c8 A3:80000818 A4:80001558 A5:00000014 A6:00000002 A7:00000003
riscv_registerdump: T0:20400004 T1:00000000 T2:00000000 T3:00000000 T4:00000000 T5:00000000 T6:00000000
riscv_registerdump: S0:80001558 S1:80000700 S2:80000000 S3:800007bc S4:80001000 S5:00000001 S6:00000000 S7:00000000
riscv_registerdump: S8:00000000 S9:00000000 S10:00000000 S11:00000000
riscv_registerdump: SP:80001030 FP:80001558 TP:00000000 RA:20403566
riscv_dumpstate: sp:     800005c0
riscv_dumpstate: IRQ stack:
riscv_dumpstate:   base: 80000060
riscv_dumpstate:   size: 00000600
riscv_stackdump: 800005c0: 00000001 00000000 00000000 deadbeef deadbeef deadbeef 00000033 2040bc14
riscv_stackdump: 800005e0: deadbeef deadbeef 00000000 00000000 00000000 00000001 80001000 800007bc
riscv_stackdump: 80000600: 80000000 80000000 00000005 2040287c deadbeef deadbeef deadbeef 20400bb2
riscv_stackdump: 80000620: deadbeef 80000000 0000000b 20400b76 deadbeef deadbeef deadbeef 2040011a
riscv_stackdump: 80000640: deadbeef deadbeef deadbeef 80000fac deadbeef 80000700 20403580 2040008a
riscv_dumpstate: sp:     80000660
riscv_dumpstate: User stack:
riscv_dumpstate:   base: 80000ac0
riscv_dumpstate:   size: 000005e0
riscv_dumpstate: ERROR: Stack pointer is not within allocated stack
riscv_stackdump: 80000ac0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ae0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000b00: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000b20: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000b40: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000b60: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000b80: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ba0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000bc0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000be0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000c00: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000c20: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000c40: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000c60: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000c80: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ca0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000cc0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ce0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000d00: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000d20: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000d40: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000d60: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000d80: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000da0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000dc0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000de0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000e00: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000e20: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000e40: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000e60: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000e80: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ea0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ec0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000ee0: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000f00: deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef deadbeef
riscv_stackdump: 80000f20: deadbeef 800007c8 fffffffc 20405f3a deadbeef 00000000 800007c8 20404c20
riscv_stackdump: 80000f40: deadbeef 80001508 80000000 204020c8 00000001 00000000 00000000 80001758
riscv_stackdump: 80000f60: 80001478 80001508 00000000 20404f4c 00000003 00000000 80001478 00000000
riscv_stackdump: 80000f80: 00000001 800011b8 fffffffc 80001508 00000003 00000000 80000690 204013d0
riscv_stackdump: 80000fa0: 00000000 00000006 8000159c 20403580 20403566 80001030 00000000 00000000
riscv_stackdump: 80000fc0: 20400004 00000000 00000000 80001558 80000700 00000002 80000700 800015c8
riscv_stackdump: 80000fe0: 80000818 80001558 00000014 00000002 00000003 80000000 800007bc 80001000
riscv_stackdump: 80001000: 00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000
riscv_stackdump: 80001020: 00000000 00000000 00000000 00001800 80000000 80000700 80001558 20403566
riscv_stackdump: 80001040: 800007f8 00000008 80000690 20400c5c 80000690 80001000 80000000 20400ace
riscv_stackdump: 80001060: 00000000 00000000 800010a0 00002f60 00000000 00000000 00000000 00000000
riscv_stackdump: 80001080: 00000000 00000000 00000000 20400188 00000000 00000000 00000000 20400026
riscv_showtasks:    PID    PRI      USED     STACK   FILLED    COMMAND
riscv_showtasks:   ----   ----       496      1536    32.2%    irq
riscv_dump_task:      0      0       380      1504    25.2%    Idle Task
riscv_dump_task:      1    100       612      1496    40.9%    nsh_main

@no1wudi
Copy link
Contributor Author

no1wudi commented Dec 30, 2021

@masayuki2009 Please take a look : #5123

@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@no1wudi @masayuki2009 @xiaoxiang781216