Refine POSTBUILD for spresense and esp32-core #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
reviewed
Mar 23, 2020
| reliant on the esp-idf design for these parts. Both are possible. | ||
|
|
||
| config ESP32CORE_BINARY | ||
| bool "esp32 binary format" |
Contributor
There was a problem hiding this comment.
this is misleading as it's just a flash image.
how about "Flash image (mainly for QEMU)"
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Ouss4
approved these changes
Mar 23, 2020
Member
Ouss4
left a comment
Ouss4
left a comment
There was a problem hiding this comment.
Thanks Xiang. We are good as far as the issue discussed in testing/
The build failure is another topic.
Contributor
|
+1 but it failed the checks and I am unable to test locally due to network constrains |
patacongo
approved these changes
Mar 23, 2020
Contributor
patacongo
left a comment
patacongo
left a comment
There was a problem hiding this comment.
This looks like a proper solution and it is consistent with the CXD56xx solution. Will the build tests restart automatically so that we can confirm that?
Member
I re-run the CI checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.