fs: Move mmap callback before truncate in [file|mountpt]_operations #8021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
mmap
branch
3 times, most recently
from
d65e5c3 to
50c245d
Compare
jlaitine
approved these changes
Jan 3, 2023
since mmap may exist in block_operations, but truncate may not, moving mmap beforee truncate could make three struct more compatible Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
mmap
branch
2 times, most recently
from
93a518f to
6eca589
Compare
pkarashchenko
approved these changes
Jan 4, 2023
xiaoxiang781216
force-pushed
the
mmap
branch
2 times, most recently
from
55fd8b5 to
3df518d
Compare
pkarashchenko
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since mmap may exist in block_operations, but truncate may not, moving mmap beforee truncate could make three struct more compatible.
Fix the issue found in: #8000
Impact
Minor
Testing
Pass CI