mm/map: Remove the unnessary map.h inclusion in various drivers #8028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Fix include/nuttx/mm/map.h:55:28: error: 'struct task_group_s' declared inside parameter list will not be visible outside of this definition or declaration Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Contributor
Author
Contributor
What is the error exactly? The struct task_group_s needs to be forward declared in map.h. map.h is included in fs.h, but not every driver using map.h uses fs.h you'll end up in circular dependencies between fs.h <-> sched.h <-> map.h, because sched.h includes fs.h. I think I did this properly by forward declaring struct task_group_s in map.h, and included map.h in places where the mm_map is used. Actually, things should work in #8026 |
Contributor
jlaitine
approved these changes
Jan 5, 2023
pkarashchenko
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
and Fix include/nuttx/mm/map.h:55:28: error: 'struct task_group_s' declared inside parameter list will not be visible outside of this definition or declaration
Impact
Fix build break
Testing
Pass CI