Skip to content

feat(services/etcd): introduce new service backend etcd#2672

Merged
Xuanwo merged 6 commits intoapache:mainfrom
G-XD:feat-etcd
Jul 21, 2023
Merged

feat(services/etcd): introduce new service backend etcd#2672
Xuanwo merged 6 commits intoapache:mainfrom
G-XD:feat-etcd

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Jul 19, 2023

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 19, 2023
Xuanwo
Xuanwo reviewed Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Your code is perfect!

Comment thread core/src/types/scheme.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 19, 2023

CI failed for we don't have protoc installed. Let me take a look.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 20, 2023

Hi, I have added protoc in #2674, would you like to take another try?

@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Jul 20, 2023 •
edited
Loading

Hi, check_clippy and Service Test WebDAV are failed, do I just need to fix the check_clippy related errors?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 20, 2023 •
edited
Loading

Please ignore the error happened in Service Test WebDAV, we are working on addressing it.

For check_clippy errors: yes, please fix all of them.

@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Jul 21, 2023

Please ignore the error happened in Service Test WebDAV, we are working on addressing it.

For check_clippy errors: yes, please fix all of them.

Hi, I'm done and it looks fine.

Xuanwo
Xuanwo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 5750dfc into apache:main Jul 21, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 21, 2023

Would you like to add an integration test for etcd service?

@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Jul 21, 2023

Okay, I'll try it.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 21, 2023

Okay, I'll try it.

Thanks a lot!

@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G-XD @Xuanwo