Skip to content

ci: Setup protoc in rust builder#2674

Merged
Xuanwo merged 4 commits intomainfrom
add-protoc
Jul 20, 2023
Merged

ci: Setup protoc in rust builder#2674
Xuanwo merged 4 commits intomainfrom
add-protoc

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jul 20, 2023

Add a step in the rust environment setup action to set up the protoc compiler. Currently used by tikv and etcd services.

Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Jul 20, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Copy Markdown
Member

Any service who need this?😯Should we use a variable to enable it or not?

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 20, 2023

Any service who need this?hushedShould we use a variable to enable it or not?

tikv and etcd.

@suyanhanx
Copy link
Copy Markdown
Member

Any service who need this?hushedShould we use a variable to enable it or not?

tikv and etcd.

😅Need a ticket to the infra...

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 20, 2023

Need a ticket to the infra...

Let's make this work simple.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants