Skip to content

feat(services/tikv): introduce new service backend tikv#2565

Merged
Xuanwo merged 12 commits intoapache:mainfrom
oowl:feat/service/tikv
Jul 23, 2023
Merged

feat(services/tikv): introduce new service backend tikv#2565
Xuanwo merged 12 commits intoapache:mainfrom
oowl:feat/service/tikv

Conversation

@oowl
Copy link
Copy Markdown
Member

@oowl oowl commented Jun 28, 2023

No description provided.

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 28, 2023
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jun 28, 2023

blocked by tikv/client-rust#395 (comment)

@oowl oowl marked this pull request as draft June 28, 2023 17:47
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 9, 2023

TiKV has migrated it's grpc client to tonic at tikv/client-rust#399

We will need to wait for tikv 0.3

@oowl oowl force-pushed the feat/service/tikv branch from b98844b to c4b8aba Compare July 11, 2023 03:07
Xuanwo
Xuanwo reviewed Jul 11, 2023
View reviewed changes
Comment thread core/Cargo.toml
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 13, 2023

tikv_client v0.2 has been released, let's rock: https://docs.rs/tikv-client/latest/tikv_client/

@oowl oowl force-pushed the feat/service/tikv branch 2 times, most recently from eec849a to 1a51fff Compare July 13, 2023 17:22
@oowl oowl marked this pull request as ready for review July 13, 2023 17:22
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jul 13, 2023

I will add test action in another PR.

Xuanwo
Xuanwo reviewed Jul 13, 2023
View reviewed changes
Comment thread core/src/services/mod.rs Outdated
Comment thread core/src/services/tikv/backend.rs Outdated
Comment thread core/src/services/tikv/backend.rs Outdated
Comment thread core/src/services/tikv/backend.rs Outdated
Comment thread core/src/services/tikv/backend.rs Outdated
Xuanwo
Xuanwo reviewed Jul 13, 2023
View reviewed changes
Comment thread core/Cargo.toml Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 13, 2023

I submitted a PR tikv/client-rust#411 to remove the need of PROTOC.

@oowl oowl marked this pull request as draft July 14, 2023 03:38
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 20, 2023

Hi, @oowl, I have added protoc in #2674. Would you like to take another try?

oowl added 4 commits July 23, 2023 15:11
@oowl
feat(services/tikv): introduce new service backend tikv
f0defd1 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
2e37fb4 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
05eacb2 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
07c89a6 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/service/tikv branch from 609f85f to 07c89a6 Compare July 23, 2023 07:16
oowl added 5 commits July 23, 2023 15:21
@oowl
feat(services/tikv): fix code
2d6e282 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
edcee3e 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
35dd1db 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
747ffb8 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
98c7c33 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(services/tikv): fix code
6ceab0d 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jul 23, 2023

I will add tikv integration test in next PR.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 23, 2023

I will add tikv integration test in next PR.

LGTM.

@oowl
feat(services/tikv): fix code
1fdc0a8 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl marked this pull request as ready for review July 23, 2023 09:15
@oowl oowl force-pushed the feat/service/tikv branch from 1fdc0a8 to 9ba4465 Compare July 23, 2023 09:16
@oowl oowl requested a review from Xuanwo July 23, 2023 09:21
Xuanwo
Xuanwo reviewed Jul 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great PR!

Comment thread core/src/services/tikv/backend.rs Outdated
Comment thread core/src/services/tikv/backend.rs
Xuanwo
Xuanwo reviewed Jul 23, 2023
View reviewed changes
Comment thread core/src/services/tikv/backend.rs Outdated
@oowl
feat(services/tikv): fix code
cfaadf7 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/service/tikv branch from 9ba4465 to cfaadf7 Compare July 23, 2023 10:23
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 23, 2023

Great, let's go!

@Xuanwo Xuanwo merged commit 6fd6697 into apache:main Jul 23, 2023
@Xuanwo Xuanwo mentioned this pull request Jul 23, 2023
Closed
7 tasks
This was referenced Jul 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oowl @Xuanwo