Skip to content

Bump version 0.2.0#395

Merged
andylokandy merged 2 commits intotikv:masterfrom
andylokandy:bump
Jun 27, 2023
Merged

Bump version 0.2.0#395
andylokandy merged 2 commits intotikv:masterfrom
andylokandy:bump

Conversation

@andylokandy
Copy link
Copy Markdown
Collaborator

Signed-off-by: Andy Lok andylokandy@hotmail.com

Closes #391

Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy andylokandy requested review from ekexium and nrc May 25, 2023 02:22
@andylokandy
Copy link
Copy Markdown
Collaborator Author

It's weird to fail on this test case

@andylokandy
Copy link
Copy Markdown
Collaborator Author

@ekexium On tests/integration_tests.rs:659, txn.put(vec![1], vec![42]).await returns

Err(
    PessimisticLockError {
        inner: ResolveLockError,
        success_keys: [],
    },
)

Do you have any idea?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 26, 2023

Hi, @ekexium would you like to take a look? Is there any help I can provide?

@ekexium
Copy link
Copy Markdown
Collaborator

ekexium commented Jun 26, 2023

Sorry guys I don't have much time to check the issues here recently.
Seems to me it might be caused by a behavior change in TiKV 7.1 introduced in tikv/tikv#14293. An insert can return AlreadyExist error when the key exists. Commenting out this line txn.insert(vec![2], vec![42]).await?; lets me pass the test.

I believe there is also a problem with the pessimistic backoff (#367).

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 27, 2023

#396 has been merged, let's try again!

@andylokandy andylokandy merged commit 8875c96 into tikv:master Jun 27, 2023
@oowl
Copy link
Copy Markdown

oowl commented Jun 28, 2023

@andylokandy Hi, it seems this version bump does not cargo publish to creates.io https://crates.io/crates/tikv-client

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 29, 2023

@ekexium would you like to help publish this crate?

@ekexium
Copy link
Copy Markdown
Collaborator

ekexium commented Jun 29, 2023

I don't have the owner permission of this crate. @andylokandy do you?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 29, 2023

image

@andylokandy
Copy link
Copy Markdown
Collaborator Author

andylokandy commented Jun 30, 2023

Sorry guys. I'm having a problem uploading this crate since it has a git patch dependency, namly protobuf, because of which crates.io refues to accept it.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 30, 2023

Sorry guys. I'm having a problem uploading this crate since it has a git patch dependency, namly protobuf, because of which crates.io refues to accept it.

Tracked at #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: cannot compile tikv-client on crates.io with high versioned GNU tool chain

4 participants