fix(binding/java): decode Java’s modified UTF-8 format#3195
Merged
tisonkun merged 3 commits intoapache:mainfrom Sep 27, 2023
G-XD:fix_java_binding
Merged
fix(binding/java): decode Java’s modified UTF-8 format#3195tisonkun merged 3 commits intoapache:mainfrom G-XD:fix_java_binding
tisonkun merged 3 commits intoapache:mainfrom
G-XD:fix_java_binding
Conversation
tisonkun
requested changes
Sep 26, 2023
Member
tisonkun
left a comment
There was a problem hiding this comment.
Let's factor out this repeat conversion into jstring_to_string:
fn jstring_to_string(env: &mut JNIEnv, s: &JString) -> Result<String> {
let res = unsafe { env.get_string_unchecked(&s)? };
Ok(res.into())
}I suspect we may have more thoughts on this conversion, so open to change.
Xuanwo
reviewed
Sep 27, 2023
tisonkun
approved these changes
Sep 27, 2023
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #3194