Skip to content

refactor(services/supabase): migrate to test planner#3406

Merged
Xuanwo merged 2 commits intomainfrom
supabase_test_planner
Oct 30, 2023
Merged

refactor(services/supabase): migrate to test planner#3406
Xuanwo merged 2 commits intomainfrom
supabase_test_planner

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Oct 27, 2023

No description provided.

@G-XD G-XD requested review from PsiACE and Xuanwo as code owners October 27, 2023 15:48
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 27, 2023
@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Oct 27, 2023

Hi @Xuanwo , Should the testWriteFileWithNonAsciiName test be removed? This test was added separately due to #3195 and it is not synchronized with the rust behavior test.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 30, 2023

Should the testWriteFileWithNonAsciiName test be removed?

Yes, I think we should remove this test first until we know how to play with non ascii on different services.

# Conflicts:
#	.github/workflows/service_test_supabase.yml
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 3362b13 into main Oct 30, 2023
@Xuanwo Xuanwo deleted the supabase_test_planner branch October 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants