-
Notifications
You must be signed in to change notification settings - Fork 741
refactor: Introduce OpenDAL Workflow Planner #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
65f363d
Try workflow call
Xuanwo 68feacf
Add s3 as ignore example
Xuanwo a5212dc
Fix
Xuanwo 825fa88
Remove concurrency
Xuanwo 6ab5ce1
Use output file
Xuanwo d3aa462
Let's go
Xuanwo 66d71db
wrap
Xuanwo 7ae4245
Fix typo
Xuanwo 42e86d2
test
Xuanwo 0134f32
Polish naming
Xuanwo 7b3917e
polish naming
Xuanwo 00ed34e
Can we use / ?
Xuanwo 3501ac7
Try
Xuanwo 81e551c
Fix
Xuanwo 5635eb2
Fix build
Xuanwo bb88a0b
polish matrix
Xuanwo 8975ebe
Fix not found
Xuanwo 947000d
Fix path
Xuanwo 3444ed1
FIx path
Xuanwo 7e91e3f
try
Xuanwo 6b356af
Fix typo
Xuanwo 77bed37
toJson
Xuanwo e23d139
Fix typo
Xuanwo 7ad8fcd
polish naming
Xuanwo d1039aa
FIx build
Xuanwo afbb79d
Auto detect task
Xuanwo b28c976
better
Xuanwo f64c752
Polish fs
Xuanwo 2d8dbda
Add s3
Xuanwo 85a69e9
Make json pretty
Xuanwo 03860f1
Make sure secrets
Xuanwo c0287e3
Try passing
Xuanwo 24f1961
Use from json
Xuanwo defbe26
Fix
Xuanwo 0642f34
Remove migrated tests
Xuanwo a934335
remove unused functions
Xuanwo 342d525
Work under push event
Xuanwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: Test Core | ||
| description: 'Test Core with given setup and service' | ||
| inputs: | ||
| setup: | ||
| description: "The setup action for test" | ||
| service: | ||
| description: "The service to test" | ||
| secrets: | ||
| description: "The secrets for test" | ||
| default: "{}" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Setup | ||
| shell: bash | ||
| run: | | ||
| mkdir -p ./dynamic_test_core && | ||
| cat <<EOF >./dynamic_test_core/action.yml | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Setup Test Core | ||
| uses: ./.github/services/${{ inputs.service }}/${{ inputs.setup }} | ||
| with: | ||
| secrets: ${{ toJson(inputs.secrets) }} | ||
| - name: Run Test Core | ||
| shell: bash | ||
| working-directory: core | ||
| run: cargo nextest run services_${{ inputs.service }} --archive-file=./core-test.tar.zst | ||
| EOF | ||
| - name: Run | ||
| id: run | ||
| uses: ./dynamic_test_core | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: local_fs | ||
| description: "Setup local fs" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Setup | ||
| shell: bash | ||
| run: | | ||
| echo "OPENDAL_FS_TEST=on" >> $GITHUB_ENV | ||
| echo "OPENDAL_FS_ROOT=${{ runner.temp }}/" >> $GITHUB_ENV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: aws_s3 | ||
| description: "Setup AWS S3" | ||
|
|
||
| inputs: | ||
| secrets: | ||
| description: "The secrets for test" | ||
| default: "{}" | ||
|
|
||
| # TODO: we should migrate to 1password instead. | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Setup | ||
| shell: bash | ||
| run: | | ||
| echo "OPENDAL_S3_TEST=${{ fromJson(inputs.secrets).OPENDAL_S3_TEST }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_ROOT=${{ fromJson(inputs.secrets).OPENDAL_S3_ROOT }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_BUCKET=${{ fromJson(inputs.secrets).OPENDAL_S3_BUCKET }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_ENDPOINT=${{ fromJson(inputs.secrets).OPENDAL_S3_ENDPOINT }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_ACCESS_KEY_ID=${{ fromJson(inputs.secrets).OPENDAL_S3_ACCESS_KEY_ID }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_SECRET_ACCESS_KEY=${{ fromJson(inputs.secrets).OPENDAL_S3_SECRET_ACCESS_KEY }}" >> $GITHUB_ENV | ||
| echo "OPENDAL_S3_REGION=ap-northeast-1" >> $GITHUB_ENV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: Core | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| os: | ||
| required: true | ||
| type: string | ||
| cases: | ||
| required: true | ||
| type: string | ||
| features: | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| build: | ||
| name: build | ||
| runs-on: ${{ inputs.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup | ||
| with: | ||
| need-nextest: true | ||
| need-protoc: true | ||
| need-rocksdb: true | ||
|
|
||
| # Required by hdfs | ||
| - name: Setup java env | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: "11" | ||
|
|
||
| - name: Build | ||
| shell: bash | ||
| working-directory: core | ||
| run: | | ||
| cargo nextest archive --features ${{ inputs.features }} --archive-file ./core-test.tar.zst | ||
|
|
||
| - name: Upload | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{ inputs.os }}-core-test | ||
| path: ./core/core-test.tar.zst | ||
|
|
||
| test: | ||
| name: ${{ matrix.cases.service }} / ${{ matrix.cases.setup }} | ||
| needs: [build] | ||
| runs-on: ${{ inputs.os }} | ||
| strategy: | ||
| matrix: | ||
| cases: ${{ fromJson(inputs.cases) }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup | ||
| with: | ||
| need-nextest: true | ||
| need-protoc: true | ||
| need-rocksdb: true | ||
|
|
||
| - name: Download | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: ${{ inputs.os }}-core-test | ||
| path: ./core | ||
|
|
||
| - name: Test Core | ||
| uses: ./.github/actions/test-core | ||
| with: | ||
| setup: ${{ matrix.cases.setup }} | ||
| service: ${{ matrix.cases.service }} | ||
| secrets: ${{ toJson(secrets) }} |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.