Skip to content

refactor: Introduce OpenDAL Workflow Planner#3258

Merged
Xuanwo merged 37 commits intomainfrom
refactor-actions
Oct 13, 2023
Merged

refactor: Introduce OpenDAL Workflow Planner#3258
Xuanwo merged 37 commits intomainfrom
refactor-actions

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Oct 11, 2023

This PR aims to introduce the OpenDAL workflow planner, allowing us to reuse our test setup across different components.

image

Future works:

Build artifacts only once

How to implement the build/upload/download/test logic for java? cc @tisonkun @G-XD

Normalize the usage of service scheme

Is it possible for java & python to accept scheme in their command?

Currently:

  • java uses maven -Dtest=org.apache.opendal.test.behavior.RedisTest
  • python users pytest -vk TestMemory

Is it possible to make them accept s3/memory in command directly so that we can concat them like cargo nextest run services_${{ inputs.service }}?

cc @tisonkun @G-XD @laipz8200

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Oct 11, 2023
Xuanwo added 27 commits October 12, 2023 00:47
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review October 12, 2023 17:34
@Xuanwo Xuanwo requested a review from PsiACE as a code owner October 12, 2023 17:34
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!LGTM.

@tisonkun
Copy link
Copy Markdown
Member

tisonkun commented Oct 12, 2023

How to implement the build/upload/download/test logic for java

Something like this - korandoru/hawkeye@386d815

@tisonkun
Copy link
Copy Markdown
Member

make them accept s3/memory in command directly

Of course with JUnit's @Tag.

Comment thread scripts/workflow_planner.py Outdated
Comment thread scripts/workflow_planner.py
Comment thread .github/actions/test-core/action.yaml
@laipz8200
Copy link
Copy Markdown
Contributor

Is it possible to make them accept s3/memory in command directly so that we can concat them like cargo nextest run services_${{ inputs.service }}?

pytest has custom mark like pytest.mark.s3. By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 13, 2023

By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

Can we use abc-def with TestAbcDef?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@laipz8200
Copy link
Copy Markdown
Contributor

By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

Can we use abc-def with TestAbcDef?

Unfortunately, it cannot. pytest matches test cases by class name, function name, or custom mark (case-insensitive).

To match with abc_def, we can rename our class name or give a custom mark on it, but I think it cannot contain -. (_ is ok)

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 13, 2023

To match with abc_def, we can rename our class name or give a custom mark on it, but I think it cannot contain -. (_ is ok)

Okay, let's handle snake case conversion on the actions side instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants