refactor: Refactor pytest from class based test to function based#3263
Closed
Zheaoli wants to merge 2 commits intoapache:mainfrom
Closed
refactor: Refactor pytest from class based test to function based#3263Zheaoli wants to merge 2 commits intoapache:mainfrom
Zheaoli wants to merge 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
the
releases-note/refactor
Zheaoli
changed the title
Zheaoli
force-pushed
the
manjusaka/rename=pytest-name
branch
from
5e0bccf to
6875d81
Compare
Xuanwo
reviewed
Oct 13, 2023
| class TestMemory(AbstractTestSuite): | ||
| service_name = "memory" | ||
|
|
||
| @pytest.fixture() |
Member
There was a problem hiding this comment.
Thanks for the PR, but the class way is preferred since we want to support pytest -vk memory,s3,fs which means we could construct more operators.
Member
Author
There was a problem hiding this comment.
OKKKK，the function based can do the same thing, wait a liite bit
Member
There was a problem hiding this comment.
the function based can do the same thing
I don't understand why we need to completely change our approach just to accomplish the same thing. Are there any other benefits of using function-based tests?
Member
There was a problem hiding this comment.
But having a class make it more clear about the tests belongings:
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/rename=pytest-name
branch
from
d08abce to
0bacb4c
Compare
Member
|
I would rather close this PR as there hasn't been much improvement so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Python binding test from class-based test to function-based test.
It would improve config experience for the python binding test.
Also can support #3258