Skip to content

feat(service/azfile): add azure file service support#3312

Merged
Xuanwo merged 7 commits intoapache:mainfrom
dqhl76:azure-file-service
Oct 17, 2023
Merged

feat(service/azfile): add azure file service support#3312
Xuanwo merged 7 commits intoapache:mainfrom
dqhl76:azure-file-service

Conversation

@dqhl76
Copy link
Copy Markdown
Member

@dqhl76 dqhl76 commented Oct 17, 2023

part of: #3047

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 requested review from PsiACE and Xuanwo as code owners October 17, 2023 02:13
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 17, 2023
@dqhl76 dqhl76 marked this pull request as draft October 17, 2023 02:17
@dqhl76 dqhl76 marked this pull request as ready for review October 17, 2023 02:29
Comment thread core/src/services/azfile/backend.rs Outdated
Comment thread core/src/services/azfile/backend.rs
Comment thread core/src/services/azfile/backend.rs Outdated
Comment thread core/src/services/azfile/backend.rs
Comment thread core/src/services/azfile/backend.rs Outdated
Comment thread core/src/services/azfile/backend.rs
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's go!

@Xuanwo Xuanwo merged commit 8c6e7db into apache:main Oct 17, 2023
@dqhl76
Copy link
Copy Markdown
Member Author

dqhl76 commented Oct 17, 2023

I have a Azure File serivce account and will add integration test for next PR.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 17, 2023

I have a Azure File serivce account and will add integration test for next PR.

You can add the account to 1Password and share it with me. I will then copy it to our services vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants