Skip to content

ci(services/azfile): add azfile integration test#3409

Merged
Xuanwo merged 7 commits intomainfrom
azfile-test
Oct 29, 2023
Merged

ci(services/azfile): add azfile integration test#3409
Xuanwo merged 7 commits intomainfrom
azfile-test

Conversation

@dqhl76
Copy link
Copy Markdown
Member

@dqhl76 dqhl76 commented Oct 28, 2023

close: #3047
related: #3312

  • Add integration test for Azure file share service
  • Fix rename operation related problems
  • Add comments that discussed last PR

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 requested review from PsiACE and Xuanwo as code owners October 28, 2023 09:52
@dqhl76 dqhl76 changed the title [WIP]ci(services/azfile): add azfile integration test ci(services/azfile): add azfile integration test Oct 28, 2023
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Oct 28, 2023
Comment thread .github/workflows/service_test_azfile.yml Outdated
@dqhl76 dqhl76 requested a review from tisonkun as a code owner October 28, 2023 12:36
@dqhl76
Copy link
Copy Markdown
Member Author

dqhl76 commented Oct 28, 2023

Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Do we need to delete them?
image

@tisonkun
Copy link
Copy Markdown
Member

Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Do we need to delete them?
image

What file path you find these files?

@dqhl76
Copy link
Copy Markdown
Member Author

dqhl76 commented Oct 29, 2023

What file path you find these files?

Thanks for your reply. It is not related to random root setting. I have located the problem:

the empty directories are under the root. I found out that this was because some of our behavior tests not clean up the tested directory. For example, test_list_dir_with_metakey_complete just delete path but forget to delete parent. It is out of this PR's scope. I think this PR is ready to be reviewed.
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L141-L142
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L174

@dqhl76 dqhl76 requested a review from Xuanwo October 29, 2023 04:01
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

Comment thread bindings/java/Cargo.toml
@Xuanwo Xuanwo merged commit b2b615b into main Oct 29, 2023
@Xuanwo Xuanwo deleted the azfile-test branch October 29, 2023 06:10
@dqhl76
Copy link
Copy Markdown
Member Author

dqhl76 commented Oct 29, 2023

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Service: Add azure file service support

3 participants