Skip to content

ci(services/sftp): Move setup logic into docker-compose#3430

Merged
Xuanwo merged 13 commits intomainfrom
polish-sftp
Nov 1, 2023
Merged

ci(services/sftp): Move setup logic into docker-compose#3430
Xuanwo merged 13 commits intomainfrom
polish-sftp

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Oct 31, 2023

No description provided.

@Xuanwo Xuanwo requested review from PsiACE, silver-ymz and suyanhanx and removed request for PsiACE and messense October 31, 2023 07:44
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Oct 31, 2023
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 31, 2023

Python's CI failure can't reproduced locally...

Xuanwo added 10 commits October 31, 2023 19:02
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Oct 31, 2023

Hi, @suyanhanx, I feel unhappy when you force push my branches. Could you please avoid doing this to my work in the future? Thanks.

@suyanhanx
Copy link
Copy Markdown
Member

Hi, @suyanhanx, I feel unhappy when you force push my branches. Could you please avoid doing this to my work in the future? Thanks.

I'm very sorry. I don't feel good either. It won't happen again.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 1, 2023

Cc @suyanhanx, would you like to take a review on this PR?

Copy link
Copy Markdown
Member

@silver-ymz silver-ymz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 34f9fa0 into main Nov 1, 2023
@Xuanwo Xuanwo deleted the polish-sftp branch November 1, 2023 01:49
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants