Skip to content

chore(test): Fix sftp test failed in python#3436

Merged
Xuanwo merged 3 commits intoapache:polish-sftpfrom
Zheaoli:manjusaka/fix-sftp-test
Oct 31, 2023
Merged

chore(test): Fix sftp test failed in python#3436
Xuanwo merged 3 commits intoapache:polish-sftpfrom
Zheaoli:manjusaka/fix-sftp-test

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented Oct 31, 2023

Fix #3429

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli requested review from PsiACE and Xuanwo as code owners October 31, 2023 14:47
@github-actions github-actions Bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Oct 31, 2023
@Zheaoli Zheaoli marked this pull request as draft October 31, 2023 14:51
@Zheaoli Zheaoli force-pushed the manjusaka/fix-sftp-test branch from fd62991 to b5ca2a7 Compare October 31, 2023 15:13
@Zheaoli Zheaoli marked this pull request as ready for review October 31, 2023 15:13
Comment thread .github/services/sftp/sftp_with_default_root/action.yml Outdated
@Xuanwo Xuanwo changed the base branch from main to polish-sftp October 31, 2023 15:18
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Oct 31, 2023

The base has been changed to #3430, you can continue your work now.

Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/fix-sftp-test branch from b5ca2a7 to 79d9b7a Compare October 31, 2023 15:22
@Zheaoli
Copy link
Copy Markdown
Member Author

Zheaoli commented Oct 31, 2023

cc @Xuanwo Done

Comment thread .github/services/sftp/sftp/action.yml Outdated
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Copy Markdown
Member Author

Zheaoli commented Oct 31, 2023

@Xuanwo PTAL

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d37e3e1 into apache:polish-sftp Oct 31, 2023
@Zheaoli Zheaoli deleted the manjusaka/fix-sftp-test branch October 31, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sftp services always failed on python binding

2 participants