Skip to content

refactor(services/persy): migrate tot test planner#3476

Merged
Xuanwo merged 6 commits intomainfrom
persy_test_planner
Nov 9, 2023
Merged

refactor(services/persy): migrate tot test planner#3476
Xuanwo merged 6 commits intomainfrom
persy_test_planner

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Nov 3, 2023

No description provided.

@G-XD G-XD requested review from PsiACE and Xuanwo as code owners November 3, 2023 13:24
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 3, 2023
@G-XD G-XD marked this pull request as draft November 3, 2023 14:10
@suyanhanx
Copy link
Copy Markdown
Member

I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.

@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Nov 6, 2023

I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.

Yes, using cargo test will work, but using nextest will fail. 😟

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.

I'd like to continue using the same testing tool for developers. How about we just use cargo test to run behavior tests instead of cargo nextest?

@suyanhanx
Copy link
Copy Markdown
Member

Let's rebase and continue this pr.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

#3505 has been merged, let's use RUST_TEST_THREADS=1 to make sure only one test running.

@G-XD G-XD force-pushed the persy_test_planner branch from ca6d884 to 964253e Compare November 7, 2023 14:31
@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Nov 7, 2023

The test for the python binding has failed, could you please take a look? cc @Xuanwo @Zheaoli

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 7, 2023

The test for the python binding has failed, could you please take a look? cc @Xuanwo @Zheaoli

Maybe you can use the tmpfs like /tmp/data.persky

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 7, 2023

Seems python will execute tests concurrently, we should fix it too.

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 7, 2023

Seems python will execute tests concurrently, we should fix it too.

No, it's not related to any concurrent problem.

Just because of the operator initial twice. I will fix this problem.

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Nov 7, 2023

#3514

Will fixed this. Already test it in local

@G-XD G-XD marked this pull request as ready for review November 9, 2023 03:26
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit dbdeadf into main Nov 9, 2023
@Xuanwo Xuanwo deleted the persy_test_planner branch November 9, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants