Skip to content

feat(binding/python): Add new API to convert between AsyncOperator and Operator#3514

Merged
messense merged 1 commit intomainfrom
manjusaka/fix-operator-error
Nov 9, 2023
Merged

feat(binding/python): Add new API to convert between AsyncOperator and Operator#3514
messense merged 1 commit intomainfrom
manjusaka/fix-operator-error

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented Nov 7, 2023

Related to #3476

  1. Add new blocking API like https://github.com/apache/incubator-opendal/blob/main/bindings/java/src/operator.rs#L288-L296. This is allow people share a same rust core operator between AsyncOperator and Operator to avoid some file lock issue in file based database.
  2. Change the pytest fixture scope from function to session.

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli requested a review from messense as a code owner November 7, 2023 17:02
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 7, 2023
Comment thread bindings/python/src/operator.rs
Comment thread bindings/python/python/opendal/__init__.pyi Outdated
Comment thread core/src/types/operator/blocking_operator.rs Outdated
Comment thread bindings/python/python/opendal/__init__.pyi Outdated
@Zheaoli Zheaoli force-pushed the manjusaka/fix-operator-error branch from 9d560de to e9f16bd Compare November 8, 2023 14:33
@Zheaoli Zheaoli force-pushed the manjusaka/fix-operator-error branch from e9f16bd to 7b8ad3c Compare November 8, 2023 14:33
@Zheaoli Zheaoli requested review from Xuanwo and messense November 8, 2023 14:33
@Xuanwo Xuanwo changed the title feat(binding/python): Add new API to convert AsyncOperator to Operator feat(binding/python): Add new API to convert between AsyncOperator and Operator Nov 8, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 8, 2023

cc @messense for another review

@messense messense merged commit e0ccc9e into main Nov 9, 2023
@messense messense deleted the manjusaka/fix-operator-error branch November 9, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants